Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send vl_api_sockclnt_delete_t message on disconnect #248

Merged
merged 1 commit into from
Nov 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions adapter/socketclient/socketclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,10 @@ func (c *Client) Disconnect() error {
// wait for readerLoop to return
c.wg.Wait()

// Don't bother sending a vl_api_sockclnt_delete_t message,
// just close the socket.
if err := c.close(); err != nil {
log.Debugf("closing failed: %v", err)
}

if err := c.disconnect(); err != nil {
return err
}
Expand Down Expand Up @@ -408,6 +410,49 @@ func (c *Client) open(clientName string) error {
return nil
}

func (c *Client) close() error {
var msgCodec = codec.DefaultCodec

req := &memclnt.SockclntDelete{
Index: c.clientIndex,
}
msg, err := msgCodec.EncodeMsg(req, c.sockDelMsgId)
if err != nil {
log.Debugln("Encode error:", err)
return err
}
setMsgRequestHeader(msg, c.clientIndex, uint32(deleteMsgContext))

log.Infof("sending socklntDel (%d bytes): % 0X", len(msg), msg)

if err := c.writeMsg(msg); err != nil {
log.Debugln("Write error: ", err)
return err
}

msgReply, err := c.readMsgTimeout(nil, c.disconnectTimeout)
if err != nil {
var nerr net.Error
if errors.As(err, &nerr) && nerr.Timeout() {
log.Info("sockclnt_delete_reply: timeout")
// we accept timeout for reply
return nil
}
log.Debugln("Read sockclnt_delete_reply error:", err)
return err
}

reply := new(memclnt.SockclntDeleteReply)
if err := msgCodec.DecodeMsg(msgReply, reply); err != nil {
log.Debugln("Decoding sockclnt_delete_reply failed:", err)
return err
} else if reply.Response != 0 {
return fmt.Errorf("sockclnt_delete_reply: response error (%d)", reply.Response)
}

return nil
}

func (c *Client) setMsgTable(msgTable map[string]uint16, sockDelMsgId uint16) {
c.msgTableMu.Lock()
defer c.msgTableMu.Unlock()
Expand Down
Loading