Send vl_api_sockclnt_delete_t message on disconnect #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change practically reverts previous commit [1548c7e](1548c7e), because it seems VPP is not correctly cleaning up opened sockets when they are closed from client side, which increases CPU usage of VPP. This correctly sets client_index field for the message unlike previous implementation. Signed-off-by: Ondrej Fabry <[email protected]>
VladoLavor
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change practically reverts previous commit 1548c7e, because it seems VPP is not correctly cleaning up opened sockets when they are closed from client side, which increases CPU usage of VPP. This correctly sets client_index field for the message unlike previous implementation.