Allow returning result for write queries #1990
Open
+66
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonilBhavsar
changed the title
|
@tylerkaraszewski will you please review this |
tylerkaraszewski
requested changes
Dec 2, 2024
tylerkaraszewski
previously approved these changes
Dec 9, 2024
MonilBhavsar
force-pushed
the
monil-returnResultForWrites
branch
from
62b73c5 to
72bb681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
SQLite supports RETURNING clause(https://www.sqlite.org/lang_returning.html) that supports both read and write operations at a time.
Modify the SQLite handler to allow passing result reference for WRITE queries
Fixed Issues
Required for Expensify/App#51832
Tests
Tests with PR https://github.com/Expensify/Auth/pull/13393
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes