Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] You don't have access to this chat message appears when opening a report #51832

Closed
2 of 8 tasks
m-natarajan opened this issue Oct 31, 2024 · 28 comments
Closed
2 of 8 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Oct 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C05LX9D6E07/p1730309258732469

Action Performed:

  1. Login to [email protected] account
  2. Tap an unread #admins room

Expected Result:

Able to access the account

Actual Result:

You don't have access to this chat message appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021859143824351881260
  • Upwork Job ID: 1859143824351881260
  • Last Price Increase: 2024-11-25
Issue OwnerCurrent Issue Owner: @MonilBhavsar
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 31, 2024

Triggered auto assignment to @MonilBhavsar (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 31, 2024
@m-natarajan m-natarajan added Needs Reproduction Reproducible steps needed and removed Weekly KSv2 labels Oct 31, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@MonilBhavsar
Copy link
Contributor

Followed up on https://expensify.slack.com/archives/C05LX9D6E07/p1730309258732469
Will take a look at the logs...

Copy link

melvin-bot bot commented Nov 11, 2024

@MonilBhavsar, @muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

1 similar comment
Copy link

melvin-bot bot commented Nov 12, 2024

@MonilBhavsar, @muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MonilBhavsar
Copy link
Contributor

Looking into this

@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

@MonilBhavsar @muttmuure this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Nov 14, 2024
@MonilBhavsar
Copy link
Contributor

Have been looking into it and would dig into more examples. But, I very much think this is frontend issue where we're not applying an Onyx update somehow.
For Sterling's report 5517178596479675 - user on old mobile app cancelled their subscription, that deleted the policy and in turn #admins room. We even queued an onyx update to reports channel to remove #admins room report from Onyx DB, that would remove report from LHN. But somehow the part of applying Onyx update didn't work making the report appear in LHN and when clicking on it gave "Hmmm it's not there error".
The error was legit, but report should not have been visible on LHN; that's the bug,

From https://expensify.slack.com/archives/C05LX9D6E07/p1731588727678509?thread_ts=1730309258.732469&cid=C05LX9D6E07

Logs for the case https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%228da3fcd28a120f77-EWR%22)+AND+timestamp:[2024-10-29T13:52:07.629Z+TO+2024-10-29T15:52:07.629Z]&index=logs_expensify-030942

@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
Copy link

melvin-bot bot commented Nov 18, 2024

@MonilBhavsar, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

@muttmuure muttmuure added the Internal Requires API changes or must be handled by Expensify staff label Nov 19, 2024
@muttmuure
Copy link
Contributor

@MonilBhavsar is this INTERNAL or EXTERNAL?

@melvin-bot melvin-bot bot removed the Overdue label Nov 19, 2024
@MonilBhavsar MonilBhavsar added the External Added to denote the issue can be worked on by a contributor label Nov 20, 2024
@MonilBhavsar
Copy link
Contributor

Making it external

Here is the theory #51832 (comment)
The issue is flaky where applying onyx updates failed (May be because app is backgrounded and pusher is disconnected?)

Steps to reproduce :

  1. Create an account on newDot as user A
  2. As user A, create a workspace and invite user B as admin. Ensure user B sees #admins room in LHN
  3. As a user A, delete workspace
  4. As a user B, ensure #admins room is removed from LHN

Copy link

melvin-bot bot commented Nov 25, 2024

@sobitneupane, @MonilBhavsar, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2024
@muttmuure muttmuure changed the title [$250] You don't have access to this chat message appears when opening a report [$500] You don't have access to this chat message appears when opening a report Nov 25, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

Upwork job price has been updated to $500

@muttmuure
Copy link
Contributor

Making $500 so we can get this fixed

@rezkiy37
Copy link
Contributor

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

@MonilBhavsar
Copy link
Contributor

Thanks Michael!

This comment is a good summary of the issue #51832 (comment)

I noticed the Onyx updates are not being applied sometimes and hence this issue.

@melvin-bot melvin-bot bot removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Nov 26, 2024
@rezkiy37
Copy link
Contributor

Steps to reproduce :
Create an account on newDot as user A
As user A, create a workspace and invite user B as admin. Ensure user B sees #admins room in LHN
As a user A, delete workspace
As a user B, ensure #admins room is removed from LHN

I've investigated the bug and tried to reproduce it a few times. Currently, I can see the problem with data sent by Pusher. There is a message from Pusher once user A deletes the workspace. This message contains updates to particular reports. However, it misses any values that point to closing/removing/archiving the #admin channel and expense report with other workspace members. It happens only when the user shifts between reports and invokes the OpenReport command.

I see a solution where the backend sends more details (the notFound error) like OpenReport does.

Video

Bug.mp4

cc @MonilBhavsar

Copy link

melvin-bot bot commented Nov 28, 2024

@sobitneupane @MonilBhavsar @muttmuure @rezkiy37 this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@MonilBhavsar
Copy link
Contributor

Thanks for checking!
I'll take a look today

@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2024
@MonilBhavsar
Copy link
Contributor

I think I got the issue. Working and testing the fix

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2024
@MonilBhavsar MonilBhavsar added Overdue and removed Needs Reproduction Reproducible steps needed labels Nov 29, 2024
@MonilBhavsar
Copy link
Contributor

I've got draft PR's up

@MonilBhavsar
Copy link
Contributor

PR's are in review now

@MonilBhavsar MonilBhavsar added the Reviewing Has a PR in review label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

@sobitneupane, @MonilBhavsar, @muttmuure, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 12, 2024

@sobitneupane, @MonilBhavsar, @muttmuure, @rezkiy37 Huh... This is 4 days overdue. Who can take care of this?

@MonilBhavsar
Copy link
Contributor

All PR's were deployed. @rezkiy37 thank you for your help in figuring this one out. Closing

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
Development

No branches or pull requests

6 participants