Login - Infinite loading and no error message when typing wrong Magic Code.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Other

Action Performed:

1. Open the staging.new.expensify.com website.
2. Insert an account.
3. Tap on "Continue"
4. Wait for a Magic Code to be received.
5. Type an incorrect Magic Code.

Expected Result:

An error message should be automatically displayed when typing an incorrect Magic Code on login screen.

Actual Result:

Infinite loading and no error message displayed when typing an incorrect Magic Code on login screen.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6704701_1735691335174.MC.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Infinite loading and no error message displayed when typing an incorrect Magic Code on login screen.

What is the root cause of that problem?

Regression from: #52822

After login and enter the wrong magic code, we'll trigger update the failureData in

App/src/libs/actions/OnyxUpdates.ts

Line 55 in e5108a1

return updateHandler(request.failureData);

the failureData should update the isLoading to false

The queuedOnyxUpdates contains the Onyx.merge for account data, but at that time, currentAccountID is undefined, so we will filter out all key except preservedKeys. Unfortunately, preservedKeys doesn't contain account

App/src/libs/actions/QueuedOnyxUpdates.ts

Line 39 in e5108a1

queuedOnyxUpdates = queuedOnyxUpdates.filter((update) => preservedKeys.includes(update.key as OnyxKey));

so we still see the loading state

What changes do you think we should make in order to solve the problem?

1. We can add account to preservedKeys
2. We can add account conditionally when account.isLoading is true (that means the user is logging in)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should update QueuedOnyxUpdatesTest.ts to cover this case.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Result

[daledah]

@marcaaron @bfitzexpensify What do you think about my proposal? I can raise the quick PR.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[huult]

@getusha This issue was caused by our pull request. I have created a pull request to fix it. Could you take a look? Thanks!

cc @marcaaron @bfitzexpensify

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Beamanator]

PR merged & being deployed 🙏