[HOLD for payment 2025-01-24] [HOLD for payment 2025-01-13] [$500] After signing out of an account and signing into a different account, cached data remains when searching

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725058768402589

Deliverable

Provide reliable reproduction steps and a video for the below bug

Action Performed:

1. Go offline and add a comment to a report.
2. Go to Settings tab.
3. Go online and quickly logout while request is being made.
4. Sign in with a different account.
5. Click on Search Icon and observe that reports from previous account is being shown.

Expected Result:

No report that is not associated with second account should not be shown in search results.

Actual Result:

Old chats from Account A in show in search.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838371009986053911
• Upwork Job ID: 1838371009986053911
• Last Price Increase: 2024-10-09
• Automatic offers:
• huult | Contributor | 104985560

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Need to try to repro. Also should check to see how supportal into NewDot works cuz saw Expensify as a workspace option there

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021838371009986053911

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[mallenexpensify]

Updated the OP to include this for the deliverable

Provide reliable reproduction steps and a video for the below bug

[shubham1206agra]

@mallenexpensify This is happening when the ongoing request was waiting to be flushed and we trigger sign out flow.

Steps where I was able to repro this -

1. Go offline and add a comment to a report.
2. Go to Settings tab.
3. Go online and quickly logout while request is being made.

Screen.Recording.2024-09-25.at.9.53.09.AM.mov

See screenshot below for the residual data on logout

Response of BE which matches with residual data (if we combine with successData provided in API)

{
    "jsonCode": 200,
    "requestID": "8c883d48df438ad5-DEL",
    "onyxData": [
        {
            "key": "report_6652536854802253",
            "onyxMethod": "merge",
            "value": {
                "participants": {
                    "16991175": {
                        "hidden": false,
                        "notificationPreference": "always"
                    }
                }
            }
        },
        {
            "key": "report_6652536854802253",
            "onyxMethod": "merge",
            "value": {
                "chatType": "",
                "description": "",
                "lastActorAccountID": 16991175,
                "lastMessageText": "Test",
                "lastVisibleActionCreated": "2024-09-25 04:23:32.197",
                "managerID": null,
                "ownerAccountID": 0,
                "parentReportActionID": "287587431522508935",
                "parentReportID": "2758613887018111",
                "policyID": "_FAKE_",
                "reportID": "6652536854802253",
                "reportName": "Chat Report",
                "state": "OPEN",
                "stateNum": 0,
                "statusNum": 0,
                "type": "chat",
                "visibility": null
            }
        },
        {
            "key": "reportActions_6652536854802253",
            "onyxMethod": "merge",
            "shouldShowPushNotification": true,
            "value": {
                "1743823375274647167": {
                    "actionName": "ADDCOMMENT",
                    "actorAccountID": 16991175,
                    "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_16.png",
                    "created": "2024-09-25 04:23:32.197",
                    "lastModified": "2024-09-25 04:23:32.197",
                    "message": [
                        {
                            "html": "Test",
                            "text": "Test",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }
                    ],
                    "originalMessage": {
                        "html": "Test",
                        "lastModified": "2024-09-25 04:23:32.197"
                    },
                    "person": [
                        {
                            "style": "strong",
                            "text": "Sh",
                            "type": "TEXT"
                        }
                    ],
                    "reportActionID": "1743823375274647167",
                    "shouldShow": true
                }
            }
        },
        {
            "key": "personalDetailsList",
            "onyxMethod": "merge",
            "value": {
                "16991175": {
                    "accountID": 16991175,
                    "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_16.png",
                    "displayName": "Sh",
                    "firstName": "Sh",
                    "lastName": "",
                    "login": "[email protected]",
                    "phoneNumber": "",
                    "pronouns": "",
                    "status": null,
                    "timezone": {
                        "automatic": true,
                        "selected": "Asia/Calcutta"
                    },
                    "validated": true
                }
            }
        },
        {
            "key": "reportActions_2758613887018111",
            "onyxMethod": "merge",
            "value": {
                "287587431522508935": {
                    "childCommenterCount": 1,
                    "childLastActorAccountID": null,
                    "childLastMoneyRequestComment": null,
                    "childLastReceiptTransactionIDs": null,
                    "childLastVisibleActionCreated": "2024-09-25 04:23:32.197",
                    "childMoneyRequestCount": null,
                    "childOldestFourAccountIDs": "16991175",
                    "childRecentReceiptTransactionIDs": null,
                    "childReportNotificationPreference": "always",
                    "childStateNum": 0,
                    "childStatusNum": 0,
                    "childType": "chat",
                    "childVisibleActionCount": 2
                }
            }
        },
        {
            "key": "report_6652536854802253",
            "onyxMethod": "merge",
            "value": {
                "lastReadTime": "2024-09-25 04:23:32.197"
            }
        }
    ],
    "previousUpdateID": 2010501382,
    "lastUpdateID": 2022079760
}

[shubham1206agra]

Uploaded to slack - https://expensify.slack.com/archives/C049HHMV9SM/p1727239319494889?thread_ts=1725058768.402589&cid=C049HHMV9SM

Screen.Recording.2024-09-25.at.9.53.09.AM.mp4

[melvin-bot]

@madmax330, @huult, @mallenexpensify, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[huult]

The PR for this ticket has already been merged

[mallenexpensify]

Hit staging a few mins ago too. Thx @huult

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@madmax330, @huult, @mallenexpensify, @getusha Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@madmax330, @huult, @mallenexpensify, @getusha 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix clear cached data after account switch #52822

If no regressions arise, payment will be issued on 2025-01-13. 🎊

For reference, here are some details about the assignees on this issue:

• @huult requires payment automatic offer (Contributor)
• @getusha requires payment through NewDot Manual Requests

[melvin-bot]

@getusha @mallenexpensify @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[huult]

@mallenexpensify Just a gentle reminder regarding the pending payment.

[mallenexpensify]

Contributor: @huult paid $500 via Upwork
Contributor+: @getusha owed $500 via NewDot

@getusha , it looks like the BZ checklist didn't surface, can you fill it out plz?

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Fix empty e2e account #55000

If no regressions arise, payment will be issued on 2025-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @huult requires payment automatic offer (Contributor)
• @getusha requires payment through NewDot Manual Requests

[melvin-bot]

@getusha @mallenexpensify @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]