[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] [$250] [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later.

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.65-1
Reproducible in staging?: Y
**Reproducible in production?:**Y
**If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:**N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation : #convert thread

Action Performed:

1. Sign-up on expensify.com
2. Choose the “1-9” option on the home page (signUpQualifier: vsb)
3. Get redirected to new.expensify.com
4. Observe a workspace is created
5. Don’t complete the onboarding modal steps (hasCompletedGuidedSetupFlow: false)
6. Refresh the page
7. Observe another workspace is created
8. Type in expensify.com in the browser URL and click enter
9. Get redirected to new.expensify.com (classicRedirect.dismissed: false)
10. Another workspace is created

Expected Result:

If we’ve created a workspace for the new sign-up already, don’t create another one when they refresh or return.

Actual Result:

We create a workspace every time they refresh or get redirected to NewDot and haven’t completed the onboarding modal steps yet.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Refreshing the page

2024-11-21_12-29-41.mp4

Returning to expensify.com

2024-11-21_12-08-53.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859580489556912069
• Upwork Job ID: 1859580489556912069
• Last Price Increase: 2024-11-21
• Automatic offers:
• ishpaul777 | Contributor | 105120851

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[mountiny]

@nkdengineer This is coming from your PR here https://github.com/Expensify/App/pull/51839/files

We should not be creating the workspace on each mount forever. Only if there is no group policy the user is admin of yet

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Multiple workspaces get created when someone either refreshes the page, or drops off and returns later.

What is the root cause of that problem?

We are already returning early in case there is onboarding policy id set but on refresh the useOnyx will not make the data available and the effect runs too early

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Lines 61 to 62 in 2d2555b

	if (!isVsb || !!onboardingPolicyID) {
	return;

What changes do you think we should make in order to solve the problem?

We should first check that onBoarding Policy ID data is loaded not loading

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Line 48 in 2d2555b

const [onboardingPolicyID] = useOnyx(ONYXKEYS.ONBOARDING_POLICY_ID);

    const [onboardingPolicyID, onboardingPolicyIDResults] = useOnyx(ONYXKEYS.ONBOARDING_POLICY_ID);

if (!isVsb || !!onboardingPolicyID || isLoadingOnyxValue(onboardingPolicyIDResults)) {
            return;
        }

What alternative solutions did you explore? (Optional)

[FitseTLT]

@mountiny The code is already doing that but the effect runs too early for the useEffect. I have posted a fix I can immediately raise a PR if you want 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021859580489556912069

[melvin-bot]

Current assignee @jayeshmangwani is eligible for the External assigner, not assigning anyone new.

[mountiny]

@jayeshmangwani I see the offending PR is just on the fence of the 1 week regression period and it was paid out. I think its fair if you will review this PR as part of regression still. Let us know if that sounds fine with you

@FitseTLT I think your solution makes sense, you also need to add the isLoading to the useEffect dependency but sounds good.

[FitseTLT]

@jayeshmangwani I see the offending PR is just on the fence of the 1 week regression period and it was paid out. I think its fair if you will review this PR as part of regression still. Let us know if that sounds fine with you

@FitseTLT I think your solution makes sense, you also need to add the isLoading to the useEffect dependency but sounds good.

Yep I only missed it when commenting the proposal 👍

[myspace20]

@trjExpensify I requested to become a contributor through email, but I have not received feedback for a few days. Is there another way to do this?

[melvin-bot]

📣 @myspace20! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jayeshmangwani]

@jayeshmangwani I see the offending PR is just on the fence of the 1 week regression period and it was paid out. I think its fair if you will review this PR as part of regression still. Let us know if that sounds fine with you

Yes, I am definitely fine with it. We missed the case during testing

[jayeshmangwani]

@mountiny, @FitseTLT 's Suggestion looks good to me here. Should I raise a PR quickly, or will @FitseTLT do it?

[FitseTLT]

@jayeshmangwani I am already preparing 👍

[jayeshmangwani]

Cool, please do it

[jayeshmangwani]

offending PR is just on the fence of the 1 week regression period and it was paid out

@mountiny BTW, the payment for the original issue that this one is coming from hasn't been completed yet for me(I've requested on ND today). We can hold the payment until this issue is resolved. I can delete the payment request for that issue, please let me know.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later. #52899

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @FitseTLT requires payment (Needs manual offer from BZ)

[melvin-bot]

@jayeshmangwani @trjExpensify @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix - A Follow up on [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later. #53093

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @FitseTLT requires payment (Needs manual offer from BZ)

[melvin-bot]

@jayeshmangwani @trjExpensify @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ishpaul777]

👋 Please assign me here for #53093 review

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@ishpaul777 helped to jump in for urgent review, $250 to them

[trjExpensify]

Yep, sounds good!

[myspace20]

@trjExpensify please has the contributor onbording problem been resolved? I mean the slack channel among others.

[trjExpensify]

Slack access is still restricted, you will be notified when that's resolved, but there's no timeline I can give you on it.

Regardless, gaining access to Slack isn't a requirement to start putting proposals forward on issues labelled Help wanted. Have you looked at the issues available as I mentioned here?

[myspace20]

@trjExpensify Thanks I will do just that.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix - A Follow up on [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later. #53093

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @FitseTLT requires payment (Needs manual offer from BZ)
• @ishpaul777 requires payment automatic offer (Contributor)

[melvin-bot]

@jayeshmangwani / @ishpaul777 @trjExpensify @jayeshmangwani / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]