-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: move code into src, add ncc build and test against Asana board #51
Merged
dooglio
merged 13 commits into
federico/link-asana-milestone
from
doug/style-move-and-test
Sep 5, 2022
Merged
build: move code into src, add ncc build and test against Asana board #51
dooglio
merged 13 commits into
federico/link-asana-milestone
from
doug/style-move-and-test
Sep 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dooglio
commented
Sep 2, 2022
Thanks for working into this! Can you rebase this branch to get the latest changes? I fixed the issue you mention in 6ae35db. A few considerations for these changes:
|
0448a03
to
4d19197
Compare
federico-po
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved code into
src
, removednode_modules
, added@vercel/ncc
for packing and will test against asana card.Closes: this Asana task.
NOTE: don't forget the step of running
yarn build
before moving on! Since I removednode_modules
from the archive, you need to remember to commit the result of the build:dist/index.js
.Test Plan
Run against this Asana board. Make sure milestone is set correctly.
Screenshots/Videos
When attempting to assign the
![image](https://user-images.githubusercontent.com/643129/188209499-0e15f28f-cffc-460e-804e-eac43c97f3a0.png)
test
milestone, I get a failure here:However, unassigning
![image](https://user-images.githubusercontent.com/643129/188209964-8d000276-b527-4b8a-9c52-7c0fe1fbf9ba.png)
test
and assigning milestonev22.08.11
works:Further Comments