Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move code into src, add ncc build and test against Asana board #51

Merged
merged 13 commits into from
Sep 5, 2022

Conversation

dooglio
Copy link

@dooglio dooglio commented Sep 2, 2022

Summary

Moved code into src, removed node_modules, added @vercel/ncc for packing and will test against asana card.

Closes: this Asana task.

NOTE: don't forget the step of running yarn build before moving on! Since I removed node_modules from the archive, you need to remember to commit the result of the build: dist/index.js.

Test Plan

Run against this Asana board. Make sure milestone is set correctly.

Screenshots/Videos

When attempting to assign the test milestone, I get a failure here:
image

However, unassigning test and assigning milestone v22.08.11 works:
image

Further Comments

@dooglio dooglio added the enhancement New feature or request label Sep 2, 2022
@dooglio dooglio self-assigned this Sep 2, 2022
@dooglio dooglio modified the milestones: v22.08.11, test, v22.08.25 Sep 2, 2022
@dooglio dooglio requested a review from federico-po September 2, 2022 17:52
@dooglio dooglio changed the title Doug/style move and test build: move code into src, add ncc build and test against Asana board Sep 2, 2022
@federico-po
Copy link
Contributor

Thanks for working into this!

Can you rebase this branch to get the latest changes? I fixed the issue you mention in 6ae35db.

A few considerations for these changes:

  1. yarn test is failing rn, probably due to the structure.
  2. Can we add a hook or sth to automatically run yarn build? I feel like anyone would forget to run this before committing.
  3. Is it worthy to update README.md?

@dooglio dooglio force-pushed the doug/style-move-and-test branch from 0448a03 to 4d19197 Compare September 5, 2022 17:17
@dooglio dooglio added this to the test milestone Sep 5, 2022
@dooglio dooglio modified the milestones: test, v22.08.11 Sep 5, 2022
Copy link
Contributor

@federico-po federico-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@dooglio dooglio merged commit d58354c into federico/link-asana-milestone Sep 5, 2022
@dooglio dooglio deleted the doug/style-move-and-test branch September 5, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants