feat: set Asana to milestone based on PR milestone #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federico-po
force-pushed
the
federico/link-asana-milestone
branch
from
0987417 to
7113822
Compare
federico-po
force-pushed
the
federico/link-asana-milestone
branch
from
08d8ed9 to
cbef573
Compare
federico-po
force-pushed
the
federico/link-asana-milestone
branch
from
8a95be3 to
e0e7c1f
Compare
federico-po
force-pushed
the
federico/link-asana-milestone
branch
2 times, most recently
from
1999f82 to
8d7ec84
Compare
dooglio
reviewed
Aug 24, 2022
|
@dooglio Thanks for the suggestion, amigo! Updated and tested. I created a release |
|
@federico-po I'm interested to see how it goes in testing! |
|
Definitely! Feel free to follow the test plan and also I added a DEMO video (originally created for Josh so please skip the first 2 mins 😝 ) |
|
See this PR: |
…#51) * chore: remove node_modules * build: add @vercel/ncc for packaging * build: add .nvmrc * build: move supporting js files into `src` * build: add `build` step and package dist release * build: switch to node16 * build: add husky pre-commit hook to run build Co-authored-by: Federico Ponce de Leon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets the milestone in the asana tasks' linked in the PR.
Once a PR has at least one Asana task linked, and a milestone is set to the PR, the automation will run and will try to set the same milestone in the task that in the PR.
e.g. (covered by tests):
Note:
The automation will assume that:
Target Release Versionfield.asana_milestone_field_namein the GitHub action.gh_milestone_regexin the GH action.asana_milestone_regexin the GH action.Closes: this Asana task.
Test Plan
asana-actions-workflow(a console.log for example)federico/link-asana-milestoneCloses:prefix.DEMO
Further Comments
Ok GH actions are a bit tricky.
MilestonedandDemilestonedare triggered at the same time when you switch from Milestone X to Y, so they get overwritten each other and usually the tasks end up withnull(empty milestone). I added a delay of 15 secs for milestoning the task. This ensures that milestoning tasks await for some secs until demilestone happened (in case it's a re-milestoning)