Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the string isn't empty (backport #1820) #1826

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 1, 2021

This is an automatic backport of pull request #1820 done by Mergify.
Cherry-pick of adde00a has failed:

On branch mergify/bp/main/pr-1820
Your branch is ahead of 'origin/main' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit adde00a1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   tests/bugfixes/github/test_issue_ghsa_v5g7_46xf_h728.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/value.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #1826 (644aaaa) into main (0eacac6) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1826      +/-   ##
==========================================
+ Coverage   60.50%   60.52%   +0.01%     
==========================================
  Files          96       96              
  Lines       18852    18851       -1     
  Branches     9472     9471       -1     
==========================================
+ Hits        11407    11410       +3     
+ Misses       5155     5154       -1     
+ Partials     2290     2287       -3     
Impacted Files Coverage Δ
src/value.cpp 73.18% <66.66%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eacac6...644aaaa. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit 0e7d80f into main Aug 2, 2021
@mergify mergify bot deleted the mergify/bp/main/pr-1820 branch August 2, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants