Check that the string isn't empty #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbackhouse
added
bug
forward-to-main
hassec
requested changes
Jul 31, 2021
kevinbackhouse
force-pushed
the
FixIssue1819
branch
from
c51fb79
to
adde00a
Compare
hassec
approved these changes
Aug 1, 2021
kevinbackhouse
added a commit
that referenced
this pull request
Aug 2, 2021
Check that the string isn't empty (backport #1820)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1819
There were a couple of places where we checked that string wasn't empty, but then removed another character, thereby sometimes making the string empty again.
The output of
test_issue_ghsa_v5g7_46xf_h728.pychanged because I removed this check and made it safe in a different way.