Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overview] Docker v1 #31

Closed
10 of 16 tasks
kilrau opened this issue Aug 1, 2018 · 8 comments
Closed
10 of 16 tasks

[Overview] Docker v1 #31

kilrau opened this issue Aug 1, 2018 · 8 comments
Assignees

Comments

@kilrau
Copy link
Contributor

kilrau commented Aug 1, 2018

Overview issue for https://github.com/ExchangeUnion/xud-docker/

Global req: All images clean FROM golang:alpine AS build-stage

Stage 1:

Stage 2 (1.0.0-testnet):
Setup and connect dependencies as docker images

answer: simnet (Starting Simnet...)
answer: testnet (Starting Testnet...)
answer: mainnet (Not available just yet.)

Stage 3 (1.0.0-beta):

  • choose location for backup files (cloud, local network), Backup xud#917
  • choose connection mode (connect to everyone, connect to white-list only). Dependency: Whitelist P2P Mode xud#179. Needs great explainer.
  • choose channel strategy (multi-hop (autopilot = random channels), direct channels (only works with white-list atm). Needs great explainer. Difficulties to consider when operating this in production here. More details tbd
@sangaman
Copy link
Contributor

sangaman commented Aug 2, 2018

I think it's worth discussing whether we should necessarily include lnd and raiden in the docker image. Since we have the option to disable either of those, . I don't we might not always need both. I don't know if it's reasonable to have multiple docker images or the option to exclude certain components from the image for people who only want to run one or the other, but I thought I'd bring it up.

@kilrau
Copy link
Contributor Author

kilrau commented Aug 2, 2018

Definitely worth discussing:
how about a docker 'setup' asking which coins/tokens the person wants to swap with a small hint what that means (download, disk space) based on this different docker images are chosen.

@kilrau kilrau changed the title Include raiden into docker [Concept] What to include into docker Sep 6, 2018
@kilrau kilrau self-assigned this Sep 6, 2018
@kilrau kilrau assigned ghost and unassigned itsbalamurali Dec 6, 2018
@kilrau kilrau unassigned ghost Jan 2, 2019
@reliveyy
Copy link
Collaborator

reliveyy commented Feb 18, 2019

I think xud dockerfile should only care about xud itself. And we provide a docker-compose file or a k8s yaml file to describe the setup process of the whole system instead.

@kilrau
Copy link
Contributor Author

kilrau commented Feb 18, 2019

That sounds about right! @reliveyy

We can expect to use official docker lnd and raiden in future.

@reliveyy
Copy link
Collaborator

reliveyy commented Feb 19, 2019

https://github.com/reliveyy/xud-docker A quick PoC here (some services may not run properly and I will fix them later). If you have any suggestions please fire an issue in this PoC project and If the dockerization enhancement to xud is acceptable I will create a PR to this project

@kilrau kilrau changed the title [Concept] What to include into docker xud docker Feb 20, 2019
@kilrau kilrau changed the title xud docker [Overview] xud docker Mar 26, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Apr 10, 2019

I learned quite a bit from the sprkswap's docker flow today. This is the level of experience we want - things are pretty clear for me now. Added more details to the description above. Please check and let me know what you think @reliveyy @sangaman @erkarl

@kilrau kilrau changed the title [Overview] xud docker [Overview] Docker Apr 11, 2019
@kilrau kilrau removed their assignment Apr 11, 2019
@kilrau kilrau changed the title [Overview] Docker Docker Apr 11, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Apr 17, 2019

I think it's worth discussing whether we should necessarily include lnd and raiden in the docker image. Since we have the option to disable either of those, . I don't we might not always need both. I don't know if it's reasonable to have multiple docker images or the option to exclude certain components from the image for people who only want to run one or the other, but I thought I'd bring it up.

Btw: That's taken care of by a) user choosing supported coins/tokens and also b) ask for pre-existing nodes (#891) @sangaman .

@kilrau kilrau changed the title Docker Docker v1 Jun 11, 2019
@kilrau kilrau transferred this issue from ExchangeUnion/xud Jun 11, 2019
@kilrau kilrau changed the title Docker v1 [Overview] Docker v1 Jun 17, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Jul 22, 2019

Continuing in #30. Closing here.

@kilrau kilrau closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants