Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel management #909

Closed
kilrau opened this issue Apr 26, 2019 · 3 comments
Closed

Channel management #909

kilrau opened this issue Apr 26, 2019 · 3 comments
Labels
in progress lightning Lightning network & lnd integration P1 top priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Apr 26, 2019

Motivation:

Our new docker setup will ask for a "channel strategy" - direct or multi-hop. Due to a serious raiden routing issue (raiden uses a new secret for every new route it tries) we probably have to make direct channels the default for now and only allow multi-hop for btc and ltc.

Specification:

This issue is about creating a new config option for the two modes. Docker setup will manipulate this config based on user input. Also there should be a place where "Open channel with amount to xud . This will also be the place where the docker setup persist this user input.

@kilrau kilrau added lightning Lightning network & lnd integration raiden labels Apr 26, 2019
@kilrau kilrau added this to the 1.0.0-sprint.15 milestone Apr 26, 2019
@kilrau kilrau assigned ghost Apr 26, 2019
@kilrau kilrau added the P1 top priority label Apr 26, 2019
@kilrau kilrau changed the title Direct Channels Mode Direct Channel Mode Apr 26, 2019
@sangaman
Copy link
Collaborator

I don't see why we would need a config option for direct channel mode. Even given the raiden bug, if we can't swap (whether due to lack of a direct channel or for any other reason) we will fail the sanity swaps and therefore not send or accept any orders with peers for the trading pairs that can't be swapped.

@kilrau
Copy link
Contributor Author

kilrau commented Apr 27, 2019

Ok, where else would you persist this? I think we'll have several things (e.g. #169) which only make sense in direct channel mode and need to know which mode xud runs in.

@ghost
Copy link

ghost commented May 7, 2019

As discussed during the call this issue is now about:

  • enabling/disabling autopilot for swap clients that have that functionality (currently only lnd) via our gRPC
  • adding a gRPC call to open channels by providing xudPubKey, currency and amount

@ghost ghost changed the title Direct Channel Mode Channel management May 7, 2019
@kilrau kilrau modified the milestones: 1.0.0-sprint.15, 1.0.0 May 8, 2019
@kilrau kilrau removed this from the 1.0.0-beta milestone Jun 11, 2019
@ghost ghost closed this as completed Jul 10, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress lightning Lightning network & lnd integration P1 top priority
Projects
None yet
Development

No branches or pull requests

2 participants