Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup #917

Closed
kilrau opened this issue Apr 27, 2019 · 6 comments · Fixed by #1032
Closed

Backup #917

kilrau opened this issue Apr 27, 2019 · 6 comments · Fixed by #1032
Assignees
Labels

Comments

@kilrau
Copy link
Contributor

kilrau commented Apr 27, 2019

Anything I forgot?

@kilrau kilrau added this to the 1.0.0-sprint.15 milestone Apr 27, 2019
@kilrau kilrau assigned ghost , sangaman and kilrau Apr 27, 2019
@kilrau kilrau modified the milestones: 1.0.0-sprint.15, 1.0.0 May 8, 2019
@kilrau kilrau changed the title [Discussion] Backups Backup May 8, 2019
@kilrau kilrau assigned reliveyy and unassigned ghost , sangaman and kilrau May 8, 2019
@kilrau kilrau added the P1 top priority label May 8, 2019
@kilrau kilrau assigned michael1011 and unassigned reliveyy Jun 4, 2019
@michael1011
Copy link
Contributor

michael1011 commented Jun 4, 2019

As discussed I think that this should be not part of XUD by default. What would be best in my opinion is to put this functionality in a separate executable and folder in lib so that it can still reuse the config parsing and LND clients that already exist without bloating the code base too much.

Other options would be:

  • part of the XUD that can be enabled with a config parameter
  • in a separate repository (this just makes sense if we have other things to outsource from the main repository. Creating and maintaining a repo just for this is too much work in my opinion)

@kilrau @sangaman @erkarl

@sangaman
Copy link
Collaborator

sangaman commented Jun 5, 2019

You're thinking of a new script that can be run separately from xud, but still reuses some of our existing code like the LndClient? How would it be run?

@kilrau
Copy link
Contributor Author

kilrau commented Jun 5, 2019

separate executable and folder in lib

SGTM, could you quickly explain how it works and be triggered by xud before you go ahead and do it?

@michael1011
Copy link
Contributor

A new file bin/xud-backup that can be executed if the user wants to have these backups. If not the users just ignores that file and doesn't get bothered.

@kilrau kilrau removed this from the 1.0.0-beta milestone Jun 11, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Jun 25, 2019

Moved to 1.0.0-beta, we'll bring it as an (important) update to testnet.

@kilrau
Copy link
Contributor Author

kilrau commented Jul 3, 2019

EDIT: added xud db

@kilrau kilrau removed the P1 top priority label Jul 23, 2019
@kilrau kilrau added the P1 top priority label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants