Skip to content

Removing typeLookupTable #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VALERA771 merged 3 commits into from
Dec 3, 2024
Merged

Removing typeLookupTable #269

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5c0046
removing typeLookupTable
intjiraya Nov 29, 2024
a64bcaa
Return collection of custom items by type
intjiraya Dec 1, 2024
9d8e637
Deleting TryGet by type
intjiraya Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions EXILED/Exiled.CustomItems/API/Features/CustomItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ namespace Exiled.CustomItems.API.Features
/// </summary>
public abstract class CustomItem
{
private static Dictionary<Type, CustomItem?> typeLookupTable = new();
private static Dictionary<string, CustomItem?> stringLookupTable = new();
private static Dictionary<uint, CustomItem?> idLookupTable = new();

Expand Down Expand Up @@ -163,12 +162,7 @@ public virtual ItemType Type
/// </summary>
/// <param name="t">The <see cref="System.Type"/> type.</param>
/// <returns>The <see cref="CustomItem"/> matching the search, <see langwod="null"/> if not registered.</returns>
public static CustomItem? Get(Type t)
{
if (!typeLookupTable.ContainsKey(t))
typeLookupTable.Add(t, Registered.FirstOrDefault(i => i.GetType() == t));
return typeLookupTable[t];
}
public static CustomItem? Get(Type t) => Registered.FirstOrDefault(i => i.GetType() == t);

/// <summary>
/// Tries to get a <see cref="CustomItem"/> with a specific ID.
Expand Down Expand Up @@ -770,7 +764,6 @@ public virtual void Give(Player player, Item item, bool displayMessage = true)
/// </summary>
public virtual void Init()
{
typeLookupTable.Add(GetType(), this);
stringLookupTable.Add(Name, this);
idLookupTable.Add(Id, this);

Expand All @@ -784,7 +777,6 @@ public virtual void Destroy()
{
UnsubscribeEvents();

typeLookupTable.Remove(GetType());
stringLookupTable.Remove(Name);
idLookupTable.Remove(Id);
}
Expand Down