Skip to content

Removing typeLookupTable#269

Merged
VALERA771 merged 3 commits intoExMod-Team:scpsl14from
intjiraya:scpsl14
Dec 3, 2024
Merged

Removing typeLookupTable#269
VALERA771 merged 3 commits intoExMod-Team:scpsl14from
intjiraya:scpsl14

Conversation

@intjiraya
Copy link
Copy Markdown

@intjiraya intjiraya commented Nov 29, 2024

Description

Describe the changes
Removing typeLookupTable in Customitems
When attempting to create multiple CustomItem instances of the same type, an exception was thrown. The type is not a unique property for creating a dictionary.

What is the current behavior? (You can also link to an open issue here)
typeLookupTable is exists

What is the new behavior? (if this is a feature change)
no more typeLookupTable 😈

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@VALERA771
Copy link
Copy Markdown

I don't like new Get method. Maybe then make it to return collection of custom roles since we can have multiply custom roles with same time

@intjiraya
Copy link
Copy Markdown
Author

I don't like new Get method. Maybe then make it to return collection of custom roles since we can have multiply custom roles with same time

I assumed it would be a breaking change. That's why I didn't touch it.

@VALERA771
Copy link
Copy Markdown

It would but it needed. If we are making ability to create several custom roles with same type then we need to return a collection in Get method with type overload. If we return only 1 custom role it's technically not correct cuz we don't guarantee that it's the only possible custom role that found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants