Removing typeLookupTable#269
Merged
VALERA771 merged 3 commits intoExMod-Team:scpsl14from Dec 3, 2024
intjiraya:scpsl14
Merged
Conversation
IRacle1
approved these changes
Nov 30, 2024
vladflotsky
approved these changes
Nov 30, 2024
|
I don't like new Get method. Maybe then make it to return collection of custom roles since we can have multiply custom roles with same time |
Author
I assumed it would be a breaking change. That's why I didn't touch it. |
|
It would but it needed. If we are making ability to create several custom roles with same type then we need to return a collection in Get method with type overload. If we return only 1 custom role it's technically not correct cuz we don't guarantee that it's the only possible custom role that found |
VALERA771
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Removing typeLookupTable in Customitems
When attempting to create multiple
CustomIteminstances of the same type, an exception was thrown. The type is not a unique property for creating a dictionary.What is the current behavior? (You can also link to an open issue here)
typeLookupTable is exists
What is the new behavior? (if this is a feature change)
no more typeLookupTable 😈
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other