Skip to content

Respawn API changes#246

Merged
VALERA771 merged 20 commits intoExMod-Team:scpsl14from
Mikihero:newrespawnapi
Dec 9, 2024
Merged

Respawn API changes#246
VALERA771 merged 20 commits intoExMod-Team:scpsl14from
Mikihero:newrespawnapi

Conversation

@Mikihero
Copy link
Copy Markdown

Description

Describe the changes
Added and changed some parts of the respawn api to reflect new changes, not done by any means

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Mikihero
Copy link
Copy Markdown
Author

a lot of this is adapted from WaveManager, still need to finish it and write & update docs

@Mikihero
Copy link
Copy Markdown
Author

there are 100% some things I shouldn't have done or should've done differently but I'm too tired to go through them myself, @Misaka-ZeroTwo @Misfiy if you could take another look and point everything out that'd be great

@Mikihero Mikihero mentioned this pull request Nov 28, 2024
8 tasks
Copy link
Copy Markdown

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can argue with me about this comments but imho this is just better

Mikihero and others added 2 commits November 28, 2024 22:12
Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com>
@Mikihero
Copy link
Copy Markdown
Author

You can argue with me about this comments but imho this is just better

agree on all of those lmao

@Mikihero
Copy link
Copy Markdown
Author

@VALERA771 do you think I should add more overloads to methods like ForceWave and similar to accept all the other ways of representing a spawn wave? shit like SpawnableTeamType Faction SpawnableFaction. Right now you can do it by using extension methods that I've added but I could just add overloads that do that for you

@Mikihero
Copy link
Copy Markdown
Author

I'm too tired too think clearly rn, someone tell me if I overcooked with this last addition

@VALERA771
Copy link
Copy Markdown

Start writing docs pls. And what overloads on spawning method you want to add?

@Mikihero
Copy link
Copy Markdown
Author

Start writing docs pls. And what overloads on spawning method you want to add?

I'll get a good chunks of the docs done today. I was talking about methods like RemoveTokens ModifyTokens GrantTokens and PlayEffect

@Mikihero
Copy link
Copy Markdown
Author

pls tell me if I've missed something

@VALERA771
Copy link
Copy Markdown

You've missed writing docs 😄

@Mikihero
Copy link
Copy Markdown
Author

wait I forgot docs for rolextensions

@VALERA771
Copy link
Copy Markdown

I don't think that we need so many seealso on overloads

@Mikihero
Copy link
Copy Markdown
Author

Mikihero commented Dec 5, 2024

I don't think that we need so many seealso on overloads

I guess that makes sense, I'll just add 1 for different (but similar) methods instead of for every overload

@VALERA771
Copy link
Copy Markdown

Timer methods have too much seealso xml docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants