Closed
Conversation
Author
|
I just realized someone already did this before between me pushing the changes and making a pr, this still adds todos to those spots so it's easier to find them all as well as some minor using clean ups |
Author
|
I have literally never done smth like this with events so please lmk if it doesn't look right |
Closed
|
Can you just write docs for these methods? |
Author
I will, I am working on #246 rn and that will need a lot of docs as well, once I'm done with that I'll work on this |
|
Waiting for docs |
Author
|
now that I'm looking at it this has like no new things, everything has been done by other prs better after I made this one |
|
You can close it then if you want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Mostly an outline of xml docs so stylecop lets me compile lol
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other