Skip to content

Changes for 14.0#201

Closed
Mikihero wants to merge 11 commits intoExMod-Team:scpsl14from
Mikihero:scpsl140
Closed

Changes for 14.0#201
Mikihero wants to merge 11 commits intoExMod-Team:scpsl14from
Mikihero:scpsl140

Conversation

@Mikihero
Copy link
Copy Markdown

Description

Describe the changes
Mostly an outline of xml docs so stylecop lets me compile lol

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Mikihero
Copy link
Copy Markdown
Author

I just realized someone already did this before between me pushing the changes and making a pr, this still adds todos to those spots so it's easier to find them all as well as some minor using clean ups

@Mikihero Mikihero changed the title Making stylecop happy for the new sl update Changes for 14.0 Nov 27, 2024
@Mikihero
Copy link
Copy Markdown
Author

I have literally never done smth like this with events so please lmk if it doesn't look right

@Mikihero Mikihero mentioned this pull request Nov 27, 2024
@VALERA771
Copy link
Copy Markdown

Can you just write docs for these methods?

@Mikihero
Copy link
Copy Markdown
Author

Can you just write docs for these methods?

I will, I am working on #246 rn and that will need a lot of docs as well, once I'm done with that I'll work on this

@VALERA771
Copy link
Copy Markdown

Waiting for docs

@Mikihero
Copy link
Copy Markdown
Author

Mikihero commented Dec 9, 2024

now that I'm looking at it this has like no new things, everything has been done by other prs better after I made this one

@VALERA771
Copy link
Copy Markdown

You can close it then if you want

@Mikihero Mikihero closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants