Fix Spawned event + no more breaking changes

EXILED/Exiled.API/Enums/EffectType.cs

@@ -218,11 +218,6 @@ public enum EffectType
         /// </summary>
         Marshmallow,
 
-        /// <summary>
-        /// Makes you metal.
-        /// </summary>
-        Metal,
-
         /// <summary>
         /// The effect that is given to the player when getting attacked by SCP-3114's Strangle ability.
         /// </summary>
@@ -293,5 +288,10 @@ public enum EffectType
         /// <see cref="CustomPlayerEffects.OrangeWitness"/>
         /// </summary>
         OrangeWitness,
+
+        /// <summary>
+        /// Makes you metal.
+        /// </summary>
+        Metal,
     }
 }

EXILED/Exiled.Events/Patches/Events/Player/ChangingRoleAndSpawned.cs

@@ -44,7 +44,6 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
             Label returnLabel = generator.DefineLabel();
             Label continueLabel = generator.DefineLabel();
             Label jmp = generator.DefineLabel();
-            Label skip = generator.DefineLabel();
 
             LocalBuilder changingRoleEventArgs = generator.DeclareLocal(typeof(ChangingRoleEventArgs));
             LocalBuilder player = generator.DeclareLocal(typeof(API.Features.Player));
@@ -154,15 +153,13 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
 
             newInstructions.InsertRange(
                 newInstructions.Count - 1,
-                new[]
+                new CodeInstruction[]
                 {
-                    // if (player.ReferenceHub == ReferenceHub.LocalHub)
-                    //     goto skip;
-                    new(OpCodes.Ldloc_S, player.LocalIndex),
-                    new(OpCodes.Callvirt, PropertyGetter(typeof(API.Features.Player), nameof(API.Features.Player.ReferenceHub))),
-                    new(OpCodes.Callvirt, PropertyGetter(typeof(ReferenceHub), nameof(ReferenceHub.LocalHub))),
-                    new(OpCodes.Call, Method(typeof(ReferenceHub), "op_Equality")),
-                    new(OpCodes.Brtrue_S, skip),
+                    // if (this.isLocalPlayer)
+                    //     return;
+                    new(OpCodes.Ldarg_0),
+                    new(OpCodes.Callvirt, PropertyGetter(typeof(PlayerRoleManager), nameof(PlayerRoleManager.isLocalPlayer))),
+                    new(OpCodes.Brtrue_S, returnLabel),
 
                     // player
                     new(OpCodes.Ldloc_S, player.LocalIndex),
@@ -175,8 +172,6 @@ private static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstructi
 
                     // Handlers.Player.OnSpawned(spawnedEventArgs)
                     new(OpCodes.Call, Method(typeof(Player), nameof(Player.OnSpawned))),
-
-                    new CodeInstruction(OpCodes.Nop).WithLabels(skip),
                 });
 
             newInstructions[newInstructions.Count - 1].labels.Add(returnLabel);