Fix Spawned event + no more breaking changes#154
Merged
louis1706 merged 39 commits intoExMod-Team:halloween-2024from Oct 29, 2024
Merged
Fix Spawned event + no more breaking changes#154louis1706 merged 39 commits intoExMod-Team:halloween-2024from
Spawned event + no more breaking changes#154louis1706 merged 39 commits intoExMod-Team:halloween-2024from
Conversation
HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT HUBERT
Halloween effects
# Conflicts: # EXILED/Exiled.API/Enums/EffectType.cs
VALERA771
changed the title
Spawned eventSpawned event + no more breaking changes
obvEve
approved these changes
Oct 25, 2024
louis1706
approved these changes
Oct 25, 2024
|
Merge it in dev and after in Halloween or do both |
obvEve
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Fixing event by simplifying check for local hub
Moved Metal EffectType to last pos cuz possible breaking change
What is the current behavior? (You can also link to an open issue here)
NRE
What is the new behavior? (if this is a feature change)
No NRE
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other