Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPRESSIONS] Add log with custom base #2324

Merged
merged 7 commits into from
May 30, 2024
Merged

Conversation

jhasm
Copy link
Contributor

@jhasm jhasm commented May 29, 2024

Resolves

  1. [EXPRESSIONS] log with custom base #2315

Summary

This change adds a new expression log to compute log with custom base.

Testing

  • Unit tests added to cover the new changes.

Related PRs

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 29, 2024
@jhasm jhasm marked this pull request as ready for review May 29, 2024 21:05
@colin-ho colin-ho self-requested a review May 29, 2024 22:57
Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhasm ! Just one comment

src/daft-dsl/src/functions/numeric/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jhasm !

@colin-ho colin-ho merged commit e99f993 into Eventual-Inc:main May 30, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants