Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPRESSIONS] log with custom base #2315

Closed
colin-ho opened this issue May 28, 2024 · 4 comments
Closed

[EXPRESSIONS] log with custom base #2315

colin-ho opened this issue May 28, 2024 · 4 comments
Assignees
@jhasm
Labels
expression A new expression good first issue Good for newcomers

Comments

@colin-ho
Copy link
Contributor

colin-ho commented May 28, 2024 •
edited
Loading

log(base : float)

Compute the log of a numeric column using a given base, default to base = e.

See #2168 for a reference PR
@colin-ho colin-ho added expression A new expression good first issue Good for newcomers labels May 28, 2024
@jhasm
Copy link
Contributor

jhasm commented May 29, 2024

working on this

@jhasm
Copy link
Contributor

jhasm commented May 29, 2024

Question @colin-ho, why do we want to use an int type if the default value is a float (e = 2.718) ?

@colin-ho
Copy link
Contributor Author

Question @colin-ho, why do we want to use an int type if the default value is a float (e = 2.718) ?

Should be float, that's my bad.

@jhasm jhasm mentioned this issue May 29, 2024
Merged
@jhasm
Copy link
Contributor

jhasm commented May 29, 2024

PR to address this #2324

colin-ho pushed a commit that referenced this issue May 30, 2024
@jhasm
[EXPRESSIONS] Add log with custom base (#2324)
e99f993 
### Resolves 
1. #2315

### Summary
This change adds a new expression `log` to compute log with custom base.

### Testing
* Unit tests added to cover the new changes.

### Related PRs
* #2168 used as a reference to
keep all log related expressions uniform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhasm jhasm

Labels
expression A new expression good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colin-ho @jhasm