Fix cpu6 detect #34
Open
Fix cpu6 detect #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to set V flag depending on value for various cpu6 detection code to work
Now cpu6 detection works, code actually executes these
Sonic-Amiga
reviewed
Jul 20, 2022
| alu_out ^= ALU_V; | ||
| // Explicitly clears L and F flags | ||
| alu_out &= ~(ALU_L | ALU_F); | ||
| logic_flags(v); |
There was a problem hiding this comment.
Would be neat if you describe CPU detection logic somewhere.
There was a problem hiding this comment.
As a comment?
Code just executes a clr to a non-zero value and checks the v flag. As CPU5 doesn't implement "small immediates", it clears to zero and v flag is zero.
There was a problem hiding this comment.
Aha, got it. CPU5 ignored the remaining nibble of the operand, where the constant was pushed in in cpu6.
Still perhaps worth leaving somewhere. In code comments or maybe on wiki.
There was a problem hiding this comment.
Ah so we finally know wtf was going on. Cool
Sonic-Amiga
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLR needs to set V flag depending on value for various cpu6 detection code to work.
Also stub parity enable/disable.
Allows
?DSKTto correctly detect and report that it's running on cpu6Before:
After