Prevent dragging items outside of invsee #5902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
reviewed
Mar 24, 2025
Essentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java
Outdated
Show resolved
Hide resolved
Member
|
still need to test this but at first glance I'd want to remove the use of streams + use the |
Contributor
Author
|
I have commit new codes, but one thing to note is that this listener does not only cancel the event of dragging into armor slots but also all events of dragging into the bottom inventory. This is because the slot on the client side does not match the slot on the server side, if not so, the item may appear in a slot that was not dragged to or disappear. |
JRoy
added
type: bugfix
JRoy
changed the title
JRoy
changed the title
JRoy
approved these changes
Aug 10, 2025
Member
JRoy
left a comment
JRoy
left a comment
There was a problem hiding this comment.
Thanks for figuring this out! Appreciate it!
Euphillya
added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Aug 18, 2025
EssentialsX@2ccfad1 Add first login date to /seen (EssentialsX#6258) EssentialsX@e0e8d44 Prevent dragging items outside of invsee (EssentialsX#5902) EssentialsX@8ba7a44 Add support for snapshots in VersionUtil (EssentialsX#6265) EssentialsX@5ed43f3 Do not lowercase afk timeout commands (EssentialsX#6255) EssentialsX@69fd7bc Fix missing powertoollist permission (EssentialsX#6250) EssentialsX@302dd3f Maintain strong reference for online users (EssentialsX#6247) EssentialsX@7c89592 Add setting to preserve fly on gamemode change (EssentialsX#6238) EssentialsX@7bc91f1 Discord: Add setting to configure an HTTP Proxy for JDA (EssentialsX#6275)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3065