Skip to content

Add first login date to /seen #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JRoy merged 3 commits into from
Aug 9, 2025
Merged

Add first login date to /seen #6258

JRoy merged 3 commits into from
Aug 9, 2025

Conversation

@AdrianOliva2
Copy link
Contributor

@AdrianOliva2 AdrianOliva2 commented Aug 8, 2025 •
edited by JRoy
Loading

No description provided.

JRoy
JRoy requested changes Aug 9, 2025
View reviewed changes
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr! everything looks good but i don't think we need the last login since the seen command already tells you that?

JRoy
JRoy requested changes Aug 9, 2025
View reviewed changes
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr! everything looks good but i don't think we need the last login since the seen command already tells you that?

mdcfe
mdcfe previously requested changes Aug 9, 2025
View reviewed changes
@AdrianOliva2 AdrianOliva2 requested review from JRoy and mdcfe August 9, 2025 08:41
JRoy
JRoy approved these changes Aug 9, 2025
View reviewed changes
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@JRoy JRoy dismissed mdcfe’s stale review August 9, 2025 22:47

outdated

@JRoy JRoy changed the title Add user first and last login to command /seen Add first login date to /seen Aug 9, 2025
@JRoy JRoy added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels Aug 9, 2025
@JRoy JRoy added this pull request to the merge queue Aug 9, 2025
Merged via the queue into EssentialsX:2.x with commit 2ccfad1 Aug 9, 2025
1 check passed
@Bobcat00
Copy link
Contributor

Bobcat00 commented Aug 9, 2025

Wow, the PR that I wrote 4 years ago which you rejected.

@Evidentsinger14
Copy link
Member

Evidentsinger14 commented Aug 9, 2025

Hey @Bobcat00! You were told in your PR that it should have been configurable by permissions, and hidden by default, to which you closed your own PR instead of making those changes. The link for reference! #4618

@Bobcat00
Copy link
Contributor

Bobcat00 commented Aug 10, 2025 •
edited
Loading

Hey @Bobcat00! You were told in your PR that it should have been configurable by permissions, and hidden by default, to which you closed your own PR instead of making those changes. The link for reference! #4618

Yeah, after I was jerked around for 2 weeks. You think I was going to make even more changes, just to waste more of my time, after which you'd just come up with some other excuse not to accept it? F that.

NB: "IF we add this..."

@mbax
Copy link
Member

mbax commented Aug 10, 2025

You are not the main character, Bobcat. I'm sorry.

@EssentialsX EssentialsX locked as too heated and limited conversation to collaborators Aug 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JRoy JRoy JRoy approved these changes

@mdcfe mdcfe Awaiting requested review from mdcfe

Assignees

No one assigned

Labels

module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AdrianOliva2 @Bobcat00 @Evidentsinger14 @mbax @mdcfe @JRoy