Conversation
driskull
added
the
skip visual snapshots
jcfranco
approved these changes
Jul 26, 2024
benelan
added a commit
that referenced
this pull request
Jul 29, 2024
…-to-monorepo * origin/dev: ci: fix env var case in workflows (#9877) docs(action): deprecates the compact property (#9847) fix(tab-title): Adjust hover styling for `bordered` Tab Title (#9867) chore(themed): add token CSS variable test helper (#9860) chore: avoid deleting untracked, non-generated files on npm run clean (#9866) chore(pick-list, pick-list-item, value-list-item): fix runtime deprecation messages (#9870) refactor: create a common resource to store debounce consts (#9829) test(tree): stabilize tests (#9853) chore(value-list-item): add runtime deprecation warning (#9863) chore: release next build(deps): update dependency composed-offset-position to v0.0.6 (#9834) feat(dialog): adds new dialog component and deprecates the modal component (#9751) chore: release next fix(panel, flow-item): prevent footer slots from conflicting with each other (#9856)
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
**Related Issue:** N/A
## Summary
Try to stabilize the tree tests.
Example:
```
@esri/calcite-components:test: ● calcite-tree › keyboard support › does prevent space/enter keyboard event on actions with selectionMode of none
@esri/calcite-components:test:
@esri/calcite-components:test: expected event "keydown" to have been called 1 times, but was called 0 time
@esri/calcite-components:test:
@esri/calcite-components:test: 1065 | await page.keyboard.press("Enter");
@esri/calcite-components:test: 1066 |
@esri/calcite-components:test: > 1067 | expect(keydownSpy).toHaveReceivedEventTimes(1);
@esri/calcite-components:test: | ^
@esri/calcite-components:test: 1068 | expect(keydownSpy.lastEvent.defaultPrevented).toBe(true);
@esri/calcite-components:test: 1069 |
@esri/calcite-components:test: 1070 | await page.keyboard.press("Space");
@esri/calcite-components:test:
@esri/calcite-components:test: at Object.<anonymous> (src/components/tree/tree.e2e.ts:1067:26)
@esri/calcite-components:test:
@esri/calcite-components:test:
@esri/calcite-components:test: Test Suites: 1 failed, 1 skipped, 133 passed, 134 of 135 total
```
https://github.com/Esri/calcite-design-system/actions/runs/10085510671/job/27886423203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Try to stabilize the tree tests.
Example:
https://github.com/Esri/calcite-design-system/actions/runs/10085510671/job/27886423203