refactor: create a common resource to store debounce consts#9829
Merged
refactor: create a common resource to store debounce consts#9829
Conversation
Elijbet
force-pushed
the
elijbet/5371-common-resource-for-debounce-consts
branch
from
8c3683c to
f97ca1f
Compare
github-actions
Bot
added
the
refactor
jcfranco
requested changes
Jul 23, 2024
Member
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
This is headed in the right direction, but let's try to:
- move shared debounce delays to
calcite-components/src/utils/resources.ts - consolidate values by context (e.g., filtering, positioning)
Member
|
Agreed. Something like: export const debounceValues = {
reposition: 100,
filter: 250,
overflow: 150,
nextTick: 0
}; |
driskull
reviewed
Jul 23, 2024
| export const debounceValues = { | ||
| filter: 250, | ||
| nextTick: 0, | ||
| overflow: 150, |
Member
There was a problem hiding this comment.
I wonder if we should rename overflow to resize?
Contributor
Author
There was a problem hiding this comment.
Yeah, in this case it's wrapping the resize method.
Member
There was a problem hiding this comment.
Sounds good. Lets rename to resize 👍
jcfranco
reviewed
Jul 23, 2024
| import { SLOTS as ACTION_MENU_SLOTS } from "../action-menu/resources"; | ||
| import { Layout } from "../interfaces"; | ||
|
|
||
| export const overflowActionsDebounceInMs = 150; |
| export const debounceValues = { | ||
| filter: 250, | ||
| nextTick: 0, | ||
| overflow: 150, |
Elijbet
added
the
skip visual snapshots
jcfranco
approved these changes
Jul 26, 2024
Member
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉
🎉🥳🎉🎉🎉🥳🎉🎉🥳🥳🎉🎉🥳🥳🥳🎉🎉🥳🥳🥳🎉🥳🥳🥳🥳🎉🥳🎉
🎉🥳🥳🎉🎉🥳🎉🥳🎉🎉🥳🎉🎉🥳🎉🎉🥳🎉🎉🎉🎉🥳🎉🎉🎉🎉🥳🎉
🎉🥳🎉🥳🎉🥳🎉🥳🎉🎉🥳🎉🎉🥳🎉🎉🥳🎉🎉🎉🎉🥳🥳🥳🎉🎉🥳🎉
🎉🥳🎉🎉🥳🥳🎉🥳🎉🎉🥳🎉🎉🥳🎉🎉🥳🎉🎉🎉🎉🥳🎉🎉🎉🎉🎉🎉
🎉🥳🎉🎉🎉🥳🎉🎉🥳🥳🎉🎉🥳🥳🥳🎉🎉🥳🥳🥳🎉🥳🥳🥳🥳🎉🥳🎉
🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉
| await input.press("Tab"); | ||
|
|
||
| await page.waitForChanges(); | ||
| await page.waitForTimeout(DEBOUNCE.filter); |
Member
There was a problem hiding this comment.
As a follow-up, let's see if this extra pair of waitForXs are needed. Also, some of the E2E/Puppeteer APIs call waitForChanges under the scenes, so some calls may not be necessary.
Contributor
Author
There was a problem hiding this comment.
Sounds good, I'm removing that waitForX double, seem so to pass without it.
benelan
added a commit
that referenced
this pull request
Jul 29, 2024
…-to-monorepo * origin/dev: ci: fix env var case in workflows (#9877) docs(action): deprecates the compact property (#9847) fix(tab-title): Adjust hover styling for `bordered` Tab Title (#9867) chore(themed): add token CSS variable test helper (#9860) chore: avoid deleting untracked, non-generated files on npm run clean (#9866) chore(pick-list, pick-list-item, value-list-item): fix runtime deprecation messages (#9870) refactor: create a common resource to store debounce consts (#9829) test(tree): stabilize tests (#9853) chore(value-list-item): add runtime deprecation warning (#9863) chore: release next build(deps): update dependency composed-offset-position to v0.0.6 (#9834) feat(dialog): adds new dialog component and deprecates the modal component (#9751) chore: release next fix(panel, flow-item): prevent footer slots from conflicting with each other (#9856)
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
**Related Issue:** #5371 ## Summary Refactor: create a common resource to store debounce consts for `action-bar`, `combobox`, `filter`, `list`, `floating-ui`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #5371
Summary
Refactor: create a common resource to store debounce consts for
action-bar,combobox,filter,list,floating-ui.