Skip to content

ci(chromatic): reset baseline to dev#9746

Merged
benelan merged 5 commits intoepic/7180-component-tokensfrom
benelan/reset-chromatic-tokens-epic
Jul 10, 2024
Merged

ci(chromatic): reset baseline to dev#9746
benelan merged 5 commits intoepic/7180-component-tokensfrom
benelan/reset-chromatic-tokens-epic

Conversation

@benelan
Copy link
Copy Markdown
Contributor

@benelan benelan commented Jul 9, 2024

Summary

Reset the Chromatic baseline of the epic branch due to invalid snapshots being accepted. The baseline auto accept is disabled until the snapshots issues are resolved.

Snapshots need to be approved/rejected on both the pull request and the squashed commit on epic/7180-component-tokens. Things can get out of sync again if the new baseline on the epic branch is not accepted/rejected after installing a PR.

ref: https://www.chromatic.com/docs/branching-and-baselines/#what-if-you-accidentally-reset-your-baselines-and-are-seeing-onl

@benelan benelan requested review from a team, driskull, geospatialem and jcfranco as code owners July 9, 2024 16:23
benelan added 2 commits July 9, 2024 11:57
… benelan/reset-chromatic-tokens-epic

* origin/epic/7180-component-tokens: (222 commits)
  test(text-area): add component token E2E tests (#9729)
  test(themed): improve pseudoElement pattern
  test(rating): add theme token tests (#9700)
  test(block, block-section): add component token E2E tests (#9685)
  test(button, fab): add component token E2E tests (#9602)
  test(inline-editable): add token theme tests (#9648)
  fix(list, list-item, list-item-group): add e2e themed tests (#9616)
  test(shell-center-row): add token theming tests (#9462)
  test(shell): add token theming tests (#9458)
  fix build issues
  test(combobox, combobox-item-group, combobox-item): add component token E2E tests (#9599)
  test(radio-button): add component token E2E tests (#9591)
  test(card, card-group): add component token E2E tests (#9600)
  test(select): add component token E2E tests (#9593)
  test(icon): add component token E2E tests (#9595)
  test(label): add component token E2E tests (#9594)
  test(switch): add component token E2E tests (#9596)
  test(graph): add component token E2E tests (#9597)
  test(dropdown, dropdown-group): add component token E2E tests (#9598)
  test(tip, tip-group, tip-manager): add component token E2E tests (#9589)
  ...
@benelan benelan added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jul 9, 2024
@benelan benelan added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 9, 2024
Copy link
Copy Markdown
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks, @benelan! 🚀

Comment thread .github/workflows/chromatic-7180.yml Outdated
exitOnceUploaded: true
autoAcceptChanges: epic/7180-component-tokens
workingDir: packages/calcite-components
# Renable this option once the snapshots are fixed on the epic branch. Until then, snapshots will need to be
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: reenable

@benelan benelan merged commit be647ed into epic/7180-component-tokens Jul 10, 2024
@benelan benelan deleted the benelan/reset-chromatic-tokens-epic branch July 10, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants