test(tip, tip-group, tip-manager): add component token E2E tests#9589
Merged
jcfranco merged 2 commits intoepic/7180-component-tokensfrom Jun 18, 2024
Conversation
alisonailea
approved these changes
Jun 15, 2024
Contributor
alisonailea
left a comment
alisonailea
left a comment
There was a problem hiding this comment.
Looks good! One question
| @apply focus-base; | ||
|
|
||
| color: var(--calcite-tip-slotted-link-text-color, var(--calcite-color-brand)); | ||
| color: var(--calcite-color-brand); |
Contributor
There was a problem hiding this comment.
why did you remove --calcite-tip-slotted-link-text-color?
Member
Author
There was a problem hiding this comment.
IIRC, we added --calcite-tip-slotted-link-text-color initially in the component token update phase, but decided to not add component tokens for slotted elements in favor of having users override these directly.
Member
Author
|
@alisonailea Gonna go ahead and merge this, but LMK if we need to follow-up on #9589 (comment). |
jcfranco
deleted the
jcfranco/7180-add-tip-and-related-component-token-e2e-tests
branch
benelan
added a commit
that referenced
this pull request
Jul 9, 2024
… benelan/reset-chromatic-tokens-epic * origin/epic/7180-component-tokens: (222 commits) test(text-area): add component token E2E tests (#9729) test(themed): improve pseudoElement pattern test(rating): add theme token tests (#9700) test(block, block-section): add component token E2E tests (#9685) test(button, fab): add component token E2E tests (#9602) test(inline-editable): add token theme tests (#9648) fix(list, list-item, list-item-group): add e2e themed tests (#9616) test(shell-center-row): add token theming tests (#9462) test(shell): add token theming tests (#9458) fix build issues test(combobox, combobox-item-group, combobox-item): add component token E2E tests (#9599) test(radio-button): add component token E2E tests (#9591) test(card, card-group): add component token E2E tests (#9600) test(select): add component token E2E tests (#9593) test(icon): add component token E2E tests (#9595) test(label): add component token E2E tests (#9594) test(switch): add component token E2E tests (#9596) test(graph): add component token E2E tests (#9597) test(dropdown, dropdown-group): add component token E2E tests (#9598) test(tip, tip-group, tip-manager): add component token E2E tests (#9589) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
✨🧪✨