Skip to content

test(combobox): update test to reduce complexity #8810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alisonailea merged 1 commit into from
Feb 22, 2024
Merged

test(combobox): update test to reduce complexity #8810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/calcite-components/src/components/combobox/combobox.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,25 +1191,20 @@ describe("calcite-combobox", () => {
<calcite-combobox id="myCombobox" selection-display="fit" style="width:400px">
<calcite-combobox-item id="one" value="one" text-label="one"></calcite-combobox-item>
<calcite-combobox-item id="two" value="two" text-label="two"></calcite-combobox-item>
<calcite-combobox-item-group text-label="Last Item">
<calcite-combobox-item id="three" value="three" text-label="three"></calcite-combobox-item>
</calcite-combobox-item-group>
<calcite-combobox-item id="three" value="three" text-label="three"></calcite-combobox-item>
</calcite-combobox>
`);

const element = await page.find("#myCombobox");
await element.click();

const item1 = await page.find("calcite-combobox-item#one");
const item2 = await page.find("calcite-combobox-item#two");
const item3 = await page.find("calcite-combobox-item:last-child");
await item1.click();
await item2.click();
await item3.click();

await element.click();
await element.press("Backspace");
expect((await element.getProperty("selectedItems")).length).toBe(2);
await element.press("Delete");
Copy link
Copy Markdown
Member

@jcfranco jcfranco Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar: @eriklharper Could you look at this test suite and update the names to match the test. According to #8603, this and similar tests should test both Delete and Backspace keys.

expect((await element.getProperty("selectedItems")).length).toBe(1);
});
});

Expand Down