test(combobox): update test to reduce complexity#8810
Merged
alisonailea merged 1 commit intoepic/7180-component-tokensfrom Feb 22, 2024
Merged
test(combobox): update test to reduce complexity#8810alisonailea merged 1 commit intoepic/7180-component-tokensfrom
alisonailea merged 1 commit intoepic/7180-component-tokensfrom
Conversation
I don’t know why but adding three items always resulted in an overflow on my machine. I don’t think this change alters the actual intent of the test.
driskull
approved these changes
Feb 22, 2024
jcfranco
reviewed
Feb 22, 2024
| await element.click(); | ||
| await element.press("Backspace"); | ||
| expect((await element.getProperty("selectedItems")).length).toBe(2); | ||
| await element.press("Delete"); |
Member
There was a problem hiding this comment.
Sidebar: @eriklharper Could you look at this test suite and update the names to match the test. According to #8603, this and similar tests should test both Delete and Backspace keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
I don’t know why but adding three items always resulted in an overflow on my machine. I don’t think this change alters the actual intent of the test but it does allow it to pass locally.