Skip to content

test(commonTests): restore disabled focus target testing for non-"none" focus targets#7235

Merged
jcfranco merged 1 commit intomasterfrom
jcfranco/restore-disabled-test-assertions
Jun 27, 2023
Merged

test(commonTests): restore disabled focus target testing for non-"none" focus targets#7235
jcfranco merged 1 commit intomasterfrom
jcfranco/restore-disabled-test-assertions

Conversation

@jcfranco
Copy link
Copy Markdown
Member

@jcfranco jcfranco requested a review from Elijbet June 27, 2023 19:58
@jcfranco jcfranco requested a review from a team as a code owner June 27, 2023 19:58
@github-actions github-actions Bot added the testing Issues related to automated or manual testing. label Jun 27, 2023
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 27, 2023
@jcfranco jcfranco merged commit 52351c4 into master Jun 27, 2023
@jcfranco jcfranco deleted the jcfranco/restore-disabled-test-assertions branch June 27, 2023 22:42
@github-actions github-actions Bot added this to the 2023 July Priorities milestone Jun 27, 2023
benelan pushed a commit that referenced this pull request Jun 28, 2023
…e" focus targets (#7235)

**Related Issue:** N/A

## Summary

Restores [assertions for tab/mouse focusing on disabled
components](https://github.com/Esri/calcite-components/blame/6777b06c5dbad5441ed651d676cd9562d79e6986/packages/calcite-components/src/tests/commonTests.ts#L1044-L1064)
removed in the [`disabled` test helper
refactor](#7089).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip visual snapshots Pull requests that do not need visual regression testing. testing Issues related to automated or manual testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants