test: set up disabled helper to run a test per use case#7089
Merged
test: set up disabled helper to run a test per use case#7089
disabled helper to run a test per use case#7089Conversation
Elijbet
added
testing
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
Bot
added
the
Stale
Elijbet
removed
the
Stale
jcfranco
reviewed
Jun 16, 2023
…nd add accidentally removed click call
jcfranco
approved these changes
Jun 21, 2023
Member
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
Awesome! Thanks for helping out with this one. 🎉
| const [shadowFocusableCenterX, shadowFocusableCenterY] = await page.$eval(tabFocusTarget, (element: HTMLElement) => { | ||
| const focusTarget = element.shadowRoot.activeElement || element; | ||
| const rect = focusTarget.getBoundingClientRect(); | ||
| if (options.focusTarget === "none") { |
Member
There was a problem hiding this comment.
This test still uses resources to set up the test when the focus target is not none. I think this one needs to get merged into it("prevents focusing via keyboard and mouse") where you have different focus assertions depending on options.focusTarget.
Contributor
Author
There was a problem hiding this comment.
Take a look at the merge of those 2 tests now, does the combined test need a new title?
… explainer, some cleanup, and merge 2 tests that use the same resources
benelan
added a commit
that referenced
this pull request
Jun 27, 2023
…issue-template-checkbox * origin/master: (32 commits) ci: double build cc when publishing to workaround stencil types bug (#7227) build: bump package versions back to 1.5.0-next.5 (#7228) chore: release latest (#7144) ci: hardcode release version due to reverting feat (#7225) fix(tree-item): ensure expanded tree-item is displayed when expanded and made visible (#7216) ci(release-please): pin action version and allow manually running action (#7222) fix(input, input-number): allows numeric characters. (#7213) build(t9n): generate json file containing t9n values (#7214) chore: release next fix(combobox, dropdown, input-date-picker, input-time-picker, popover, tooltip): Prevent repositioning from affecting other floating components (#7178) build: update browserslist db (#7192) build: ignore node_modules and build outputs when watching for changes during stencil tests (#7209) test: set up `disabled` helper to run a test per use case (#7089) ci: set design complete label conditionals (#7206) chore: release next fix(list): update selectedItems property on all item selection changes (#7204) chore: fix sorting logic for t9nmanifest entries (#7203) fix(radio-button): focuses first focusable radio-button element in group. (#7152) chore: release next fix(alert): update alert queue when an alert is removed from the DOM (#7189) ...
jcfranco
added a commit
that referenced
this pull request
Jun 27, 2023
…e" focus targets (#7235) **Related Issue:** N/A ## Summary Restores [assertions for tab/mouse focusing on disabled components](https://github.com/Esri/calcite-components/blame/6777b06c5dbad5441ed651d676cd9562d79e6986/packages/calcite-components/src/tests/commonTests.ts#L1044-L1064) removed in the [`disabled` test helper refactor](#7089).
benelan
pushed a commit
that referenced
this pull request
Jun 28, 2023
…e" focus targets (#7235) **Related Issue:** N/A ## Summary Restores [assertions for tab/mouse focusing on disabled components](https://github.com/Esri/calcite-components/blame/6777b06c5dbad5441ed651d676cd9562d79e6986/packages/calcite-components/src/tests/commonTests.ts#L1044-L1064) removed in the [`disabled` test helper refactor](#7089).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #N/A
Summary
Refactor
disabledtest helper to help mitigate timeouts.Splitting up our common test helpers into individual tests helps mitigate timeouts that occurred when a helper's coverage ended up taking longer than the default test timeout.
The updated doc reflects how to use the helpers in E2E tests.