fix(icon): fix icon normalization to handle x-times-named icons #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
benelan
approved these changes
Feb 6, 2023
src/components/icon/utils.ts
Outdated
| const firstNonDigitInPartPattern = /[a-z]/i; | ||
|
|
||
| name = name | ||
| .split("-") |
There was a problem hiding this comment.
We also already split name into parts on line 66, so we can use that here instead of splitting again?
There was a problem hiding this comment.
Doh! Excellent catch! Fixing!
jcfranco
deleted the
jcfranco/6272-properly-handle-x-times-named-icons
branch
github-actions
bot
added this to the 2023 January Priorities Patch - Bugs only milestone
benelan
added a commit
that referenced
this pull request
Feb 8, 2023
…c-rulez * origin/master: docs: update component READMEs (#6352) ci(next): fix commit message (#6425) fix(vite): resolve lazying loading error in dist build (#6436) docs(changelog): remove reverted feature (#6435) revert: "feat(pagination, split-button, dropdown, date-picker) action-group): add setFocus method (#6405)" (#6426) 1.1.0-next.2 docs(segmented-control): update event description for calciteSegmentedControlChange (#6428) fix(tree-item): reverses regression to bring back focus when navigating with keyboard (#6424) fix(icon): fix icon normalization to handle x-times-named icons (#6422)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6272
Summary
This fixes an issue where our icon names weren't mapped correctly to some newly added icons (e.g.,
1x,1-8x).