Skip to content

feat(popover): add token for specifying the max width #12516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driskull merged 3 commits into from
Jul 22, 2025
Merged

feat(popover): add token for specifying the max width #12516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16181e8
feat(popover): add token for specifying the max width. #12319
driskull Jul 15, 2025
8923172
cleanup
driskull Jul 15, 2025
0bd971b
Merge branch 'dev' into dris0000/popover-max-width-token
driskull Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/calcite-components/src/components/popover/popover.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,6 +838,10 @@ describe("calcite-popover", () => {
shadowSelector: `.${CSS.container}`,
targetProp: "borderRadius",
},
"--calcite-popover-max-size-x": {
shadowSelector: `.${CSS.positionContainer}`,
targetProp: "maxInlineSize",
},
"--calcite-popover-text-color": [
{
shadowSelector: `.${CSS.heading}`,
Expand Down
2 changes: 2 additions & 0 deletions packages/calcite-components/src/components/popover/popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* @prop --calcite-popover-background-color: Specifies the component's background color.
* @prop --calcite-popover-border-color: Specifies the component's border color.
* @prop --calcite-popover-corner-radius: Specifies the component's corner radius.
* @prop --calcite-popover-max-size-x: Specifies the component's maximum width.
* @prop --calcite-popover-text-color: Specifies the component's text color.
* @prop --calcite-popover-z-index: Specifies the component's z-index value.
*/
Expand All @@ -17,6 +18,7 @@

.position-container {
@include floating-ui-container();
max-inline-size: var(--calcite-popover-max-size-x, 100vw);
}

@include floating-ui-elem-anim(".position-container");
Expand Down
1 change: 1 addition & 0 deletions packages/calcite-components/src/custom-theme/popover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export const popoverTokens = {
calcitePopoverBackgroundColor: "",
calcitePopoverBorderColor: "",
calcitePopoverCornerRadius: "",
calcitePopoverMaxSizeX: "",
calcitePopoverTextColor: "",
calcitePopoverZIndex: "",
};
Expand Down
Loading