Skip to content

refactor(semantic-tokens): rename --calcite-color-foreground-highlight to --calcite-color-surface-highlight#12488

Merged
jcfranco merged 2 commits intodevfrom
matgalla/#12390-add-surface-highlight-token
Jul 11, 2025
Merged

refactor(semantic-tokens): rename --calcite-color-foreground-highlight to --calcite-color-surface-highlight#12488
jcfranco merged 2 commits intodevfrom
matgalla/#12390-add-surface-highlight-token

Conversation

@matgalla
Copy link
Copy Markdown
Contributor

@matgalla matgalla commented Jul 10, 2025 •
edited
Loading

Related Issue: #12390

Summary

  • "Renames" --calcite-color-foreground-highlight to --calcite-color-surface-highlight

Changelog updated in #12266

@matgalla matgalla requested a review from jcfranco July 10, 2025 23:44
@matgalla matgalla self-assigned this Jul 10, 2025
@matgalla matgalla added enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. labels Jul 10, 2025
@jcfranco jcfranco changed the title feat(semantic-tokens): add --calcite-color-surface-highlight and remove --calcite-color-foreground-highlight refactor(semantic-tokens): rename --calcite-color-foreground-highlight to --calcite-color-surface-highlight Jul 11, 2025
@jcfranco jcfranco removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jul 11, 2025
@github-actions github-actions Bot added the refactor Issues tied to code that needs to be significantly reworked. label Jul 11, 2025
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed refactor Issues tied to code that needs to be significantly reworked. labels Jul 11, 2025
@jcfranco
Copy link
Copy Markdown
Member

jcfranco commented Jul 11, 2025

@matgalla We'll need to amend the PR title that added the pre-renamed token since it will be used in the changelog. Here are the steps to amend the conventional commit entry (see example).

@matgalla matgalla removed the enhancement Issues tied to a new feature or request. label Jul 11, 2025
@matgalla matgalla marked this pull request as ready for review July 11, 2025 20:11
@jcfranco jcfranco merged commit 9fceadb into dev Jul 11, 2025
15 of 16 checks passed
@jcfranco jcfranco deleted the matgalla/#12390-add-surface-highlight-token branch July 11, 2025 20:12
@github-actions github-actions Bot added this to the 2025-07-29 - Jul Milestone milestone Jul 11, 2025
benelan pushed a commit that referenced this pull request Sep 16, 2025
@matgalla @jcfranco @benelan
refactor(semantic-tokens): rename `--calcite-color-foreground-highlig…
a969c8a 
…ht` to `--calcite-color-surface-highlight` (#12488)

**Related Issue:** #12390 

## Summary

- "Renames" `--calcite-color-foreground-highlight` to
`--calcite-color-surface-highlight`

Changelog updated in #12266

---------

Co-authored-by: JC Franco <jfranco@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@matgalla matgalla

Labels

calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Milestone

2025-07-29 - Jul Milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matgalla @jcfranco