feat(accordion-item): update token naming schema#11070
Conversation
…d --calcite-accordion-item-start-icon-color
jcfranco
left a comment
There was a problem hiding this comment.
Code changes LGTM! Let’s use feat since this introduces new props. For the deprecations, please refer to the second part of the deprecation PR section in the PR review guidelines to add a separate changelog entry.
Could you also update the conventional commit description in the PR title to use the imperative, present tense? The imperative part was referenced before in our conventions, but it’s not explicitly listed now. I’ll make sure to update that today.
@alisonailea Sorry, I should've been more specific. You'll need to use a commit override in the PR description to include both @DitwanP Can you confirm? |
**Related Issue:** #10894 ## Summary This PR adds two new tokens which align with the Calcite naming schema. --calcite-accordion-item-icon-color-start --calcite-accordion-item-icon-color-end BEGIN_COMMIT_OVERRIDE deprecate(accordion-item): deprecate `--calcite-accordion-item-start-icon-color` and `--calcite-accordion-item-end-icon-color` tokens END_COMMIT_OVERRIDE
Related Issue: #10894
Summary
This PR adds two new tokens which align with the Calcite naming schema.
--calcite-accordion-item-icon-color-start
--calcite-accordion-item-icon-color-end
BEGIN_COMMIT_OVERRIDE
feat(accordion-item): update token naming schema
deprecate(accordion-item): deprecate
--calcite-accordion-item-start-icon-colorand--calcite-accordion-item-end-icon-colortokensEND_COMMIT_OVERRIDE