Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
c67df8c
chore: drop waitForChanges delay
jcfranco May 15, 2025
299b345
fix: ensure transition-duration is used in Tailwind utils
jcfranco May 16, 2025
00744e2
remove redundant style
jcfranco May 16, 2025
5c11e13
remove unnecessary delay that might trigger JSHandle disposed error
jcfranco May 16, 2025
efaa733
minor util doc update
jcfranco May 16, 2025
db3a48d
Merge branch 'jcfranco/ensure-transition-duration-in-tailwind-utils' …
jcfranco May 16, 2025
b0369c0
fix global styles test
jcfranco May 17, 2025
ad71e26
drop redundant button tests
jcfranco May 17, 2025
e487cc3
chore: add test tooling to await for animation frames within E2E page…
jcfranco May 17, 2025
286d6b6
feat(dropdown): focus items sooner on open
jcfranco May 17, 2025
35992d7
fix tests
jcfranco May 18, 2025
b0132e6
Merge branch 'dev' into jcfranco/disable-waitForChanges-timeout
jcfranco May 20, 2025
0ef4e48
fix tests
jcfranco May 20, 2025
eca300c
fix tests
jcfranco May 20, 2025
ac1a34e
drop redundant chip tests
jcfranco May 20, 2025
c986475
fix tests
jcfranco May 22, 2025
f08ffa2
chore(sheet): drop redundant openClose tests
jcfranco May 22, 2025
f1d0e13
fix tests
jcfranco May 22, 2025
79e5db1
fix tests
jcfranco May 23, 2025
d51bb8f
fix tests
jcfranco May 23, 2025
f173ee6
fix tests
jcfranco May 23, 2025
9571c51
add missing awaits
jcfranco May 23, 2025
8fc2f70
fix tests
jcfranco May 23, 2025
4588599
fix tests
jcfranco May 23, 2025
6d55f75
fix tests
jcfranco May 23, 2025
14c9b44
fix tests
jcfranco May 23, 2025
3a830a6
remove unnecessary skipAnimations
jcfranco May 24, 2025
7b211b4
drop redundant style tests
jcfranco May 24, 2025
de23b41
fix tests
jcfranco May 24, 2025
e596f11
move fn expose after page setup
jcfranco May 27, 2025
498ef7a
move fn expose after page setup
jcfranco May 27, 2025
2a88fcf
merge dev
jcfranco May 27, 2025
93a371c
fix imports
jcfranco May 27, 2025
84074d0
restore unintentional mockConsole removal
jcfranco May 27, 2025
0ebde94
group beforeClose tests
jcfranco May 27, 2025
3d2ee27
stabilize action-menu tests
jcfranco May 28, 2025
6fa2afe
tidy up sheet tests following modal
jcfranco May 28, 2025
d29784c
disable parallelism and isolation to help CI debugging process
jcfranco May 28, 2025
4999478
skip spec tests failing due to isolation for troubleshooting
jcfranco May 30, 2025
ad30ced
fix ignored promises
jcfranco May 30, 2025
1de9087
restore debugging config
jcfranco May 30, 2025
67ca9dc
chore(eslint): ban waitForEvent to avoid unstable pattern
jcfranco May 31, 2025
fe8450e
use next from event spies to wait for events instead of problematic w…
jcfranco May 31, 2025
65fd472
remove lingering only calls
jcfranco Jun 1, 2025
835cb3a
add waitForChanges after mouse-based theme interactions
jcfranco Jun 1, 2025
a790a85
tidy up meter
jcfranco Jun 1, 2025
db6602b
fix meter input HTML
jcfranco Jun 1, 2025
1852e2c
fix modal tests
jcfranco Jun 1, 2025
e826901
try delay of 1ms to help stabilize tests
jcfranco Jun 2, 2025
71928ef
move mouse scope interaction tests one level up (outside of keyboard …
jcfranco Jun 3, 2025
7961f0e
bump up delay
jcfranco Jun 3, 2025
5f7c07e
restore delay
jcfranco Jun 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/calcite-components/eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ export default tseslint.config(
property: "findAll",
message: "Use custom findAll test util for more predictable (non-empty) result usage.",
},
{
property: "waitForEvent",
message: "Use spyOnEvent and await on its next property instead for more reliable async event handling.",
},
],

"unused-imports/no-unused-imports": "error",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -375,17 +375,14 @@ describe("calcite-action-bar", () => {
expect(await groups[0].getProperty("menuOpen")).toBe(false);
expect(await groups[1].getProperty("menuOpen")).toBe(true);

const calciteActionMenuOpenEvent = page.waitForEvent("calciteActionMenuOpen");

const calciteActionMenuOpenEventSpy = await page.spyOnEvent("calciteActionMenuOpen");
await page.$eval("calcite-action-group", (firstActionGroup: ActionGroup["el"]) => {
firstActionGroup.menuOpen = true;
const event = new CustomEvent("calciteActionMenuOpen", { bubbles: true });
firstActionGroup.dispatchEvent(event);
});

await calciteActionMenuOpenEvent;

await page.waitForChanges();
await calciteActionMenuOpenEventSpy.next();

expect(groups).toHaveLength(2);
expect(await groups[0].getProperty("menuOpen")).toBe(true);
Expand Down
Loading
Loading