Merged
Conversation
github-actions
Bot
added
the
chore
…into jcfranco/disable-waitForChanges-timeout
…aitForEvent pattern
jcfranco
changed the title
jcfranco
requested review from
aPreciado88,
anveshmekala,
driskull and
eriklharper
jcfranco
changed the title
jcfranco
added
the
skip visual snapshots
benelan
pushed a commit
that referenced
this pull request
Sep 16, 2025
**Related Issue:** #10433 ## Summary This PR improves tests by: * replacing event awaiting pattern (see note on ESLint rule below) * remove redundant tests (e.g., covered by `themed` test util or screenshot tests) * remove redundant `waitForChanges` calls (`newE2EPage`, `setContent` and `E2EElement` interaction APIs call this method internally) * correct test nesting (e.g., mouse interaction group nested in keyboard interaction instead of being a sibling) * skip animations for some event-related tests * add missing `await`s ### Notes * adds `waitForAnimationFrame` for Puppeteer/E2E contexts * adds custom ESLint rule to avoid using the following pattern: ```ts const pendingEvent = e2ePageOrEl.waitForEvent("calciteFoo"); // do stuff that triggers event await pendingEvent; ``` which can lead to timing issues once the waitForChanges delay is removed, in favor of: ```ts const spy = await e2ePageOrEl.spyOnEvent("calciteFoo"); // do stuff that triggers event await spy.next(); ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #10433
Summary
This PR improves tests by:
themedtest util or screenshot tests)waitForChangescalls (newE2EPage,setContentandE2EElementinteraction APIs call this method internally)awaitsNotes
adds
waitForAnimationFramefor Puppeteer/E2E contextsadds custom ESLint rule to avoid using the following pattern:
which can lead to timing issues once the waitForChanges delay is removed, in favor of: