Skip to content

chore: include all node_modules dirs in clean script#11822

Merged
jcfranco merged 2 commits intodevfrom
jcfranco/include-all-node-modules-dirs-in-clean-script
Mar 29, 2025
Merged

chore: include all node_modules dirs in clean script#11822
jcfranco merged 2 commits intodevfrom
jcfranco/include-all-node-modules-dirs-in-clean-script

Conversation

@jcfranco
Copy link
Copy Markdown
Member

@jcfranco jcfranco commented Mar 28, 2025

Related Issue: N/A

Summary

✨🧼✨

@jcfranco jcfranco requested a review from benelan as a code owner March 28, 2025 16:06
@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Mar 28, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Mar 28, 2025
@benelan benelan requested a review from alisonailea as a code owner March 29, 2025 00:07
Copy link
Copy Markdown
Contributor

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some changes. It's set up for the clean script in each package to handle it's own stuff, and then the root one calls those. So removing node_modules doesn't need to be recursive.

Feel free to merge if my changes look good to you!

@jcfranco jcfranco merged commit a1175c0 into dev Mar 29, 2025
10 checks passed
@jcfranco jcfranco deleted the jcfranco/include-all-node-modules-dirs-in-clean-script branch March 29, 2025 07:10
@github-actions github-actions Bot added this to the 2025-04-29 - Apr Milestone milestone Mar 29, 2025
@jcfranco
Copy link
Copy Markdown
Member Author

@benelan Thanks for the assist! 🤜💥🤛

benelan added a commit that referenced this pull request Mar 31, 2025
…igration-ssr

* origin/dev: (23 commits)
  build(deps): drop @types/jsdom (#11830)
  build(deps): update arcgis to ^4.32.13 (#11832)
  build(deps): update dependency @tokens-studio/sd-transforms to v1.2.12 (#11833)
  docs: update list of contributors (#11829)
  build(deps): update dependency @types/estree to v1.0.7 (#11815)
  refactor: bump `style-dictionary` and `@tokens-studio/sd-transforms` to latest (#11655)
  chore: include all node_modules dirs in clean script (#11822)
  chore: ignore iml files (#11828)
  chore: release next
  build(deps): update nx monorepo to v20.6.4 (#11819)
  build(deps): update dependency vite to v5.4.15 (#11818)
  build(deps): update dependency @prettier/sync to v0.5.5 (#11814)
  feat(input-message): add component tokens and deprecate --calcite-input-message-spacing-value (#11759)
  fix: update tags (#11808)
  chore: cherry pick release commit from main (#11813)
  chore: release next
  build(deps): update package-lock (#11810)
  feat(flow-item): expose `FlowItemLike` type (#11791)
  revert(fab): add component tokens (#11805)
  docs(combobox, combobox-item): update token descriptions (#11806)
  ...
benelan added a commit that referenced this pull request May 14, 2025
**Related Issue:** N/A

## Summary

✨🧼✨

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants