Skip to content

fix: update tags#11808

Merged
arowles merged 1 commit intodevfrom
arowles/fix-keywords
Mar 26, 2025
Merged

fix: update tags#11808
arowles merged 1 commit intodevfrom
arowles/fix-keywords

Conversation

@arowles
Copy link
Copy Markdown
Contributor

@arowles arowles commented Mar 25, 2025

Related Issue: #

Summary

updated tags

updated tags for check icon

@github-actions github-actions Bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Mar 25, 2025
@calcite-admin calcite-admin added the skip visual snapshots Pull requests that do not need visual regression testing. label Mar 25, 2025
@jcfranco jcfranco changed the title fix: updated tags fix: update tags Mar 25, 2025
@arowles arowles requested a review from nicklu10 March 25, 2025 22:20
Copy link
Copy Markdown

@nicklu10 nicklu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@arowles
Copy link
Copy Markdown
Contributor Author

arowles commented Mar 25, 2025

@benelan and @jcfranco I noticed I am still not able to merge after 1 review. Is there a reason as to why I would 6 reviewers for this pull request?

@jcfranco
Copy link
Copy Markdown
Member

@arowles Good question. Per our release guidelines, we enable this safeguard to prevent installs while a release is in progress.

@arowles
Copy link
Copy Markdown
Contributor Author

arowles commented Mar 26, 2025

@arowles Good question. Per our release guidelines, we enable this safeguard to prevent installs while a release is in progress.

How would I get 6 reviewers? Usually our protocol for our team is about 2 reviewers when merging pull requests in other repos. To merge into this repo would I have to request reviews from the whole team?

@jcfranco
Copy link
Copy Markdown
Member

The intent is to block all installs during release. We ran into an issue during publishing and had to push it to today. We'll remove that check soon.

@arowles
Copy link
Copy Markdown
Contributor Author

arowles commented Mar 26, 2025

@jcfranco oh ok, got it. Thanks for the clarification!

@arowles arowles merged commit 3d015f7 into dev Mar 26, 2025
16 checks passed
@arowles arowles deleted the arowles/fix-keywords branch March 26, 2025 20:29
@github-actions github-actions Bot added this to the 2025-04-29 - Apr Milestone milestone Mar 26, 2025
benelan added a commit that referenced this pull request Mar 31, 2025
…igration-ssr

* origin/dev: (23 commits)
  build(deps): drop @types/jsdom (#11830)
  build(deps): update arcgis to ^4.32.13 (#11832)
  build(deps): update dependency @tokens-studio/sd-transforms to v1.2.12 (#11833)
  docs: update list of contributors (#11829)
  build(deps): update dependency @types/estree to v1.0.7 (#11815)
  refactor: bump `style-dictionary` and `@tokens-studio/sd-transforms` to latest (#11655)
  chore: include all node_modules dirs in clean script (#11822)
  chore: ignore iml files (#11828)
  chore: release next
  build(deps): update nx monorepo to v20.6.4 (#11819)
  build(deps): update dependency vite to v5.4.15 (#11818)
  build(deps): update dependency @prettier/sync to v0.5.5 (#11814)
  feat(input-message): add component tokens and deprecate --calcite-input-message-spacing-value (#11759)
  fix: update tags (#11808)
  chore: cherry pick release commit from main (#11813)
  chore: release next
  build(deps): update package-lock (#11810)
  feat(flow-item): expose `FlowItemLike` type (#11791)
  revert(fab): add component tokens (#11805)
  docs(combobox, combobox-item): update token descriptions (#11806)
  ...
benelan pushed a commit that referenced this pull request May 14, 2025
**Related Issue:** #

## Summary
**updated tags**

updated tags for check icon

Co-authored-by: Ashley Rowles <ash13874@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants