revert(menu-item): revert hover state interaction changes#11761
Merged
aPreciado88 merged 4 commits intodevfrom Mar 19, 2025
Merged
revert(menu-item): revert hover state interaction changes#11761aPreciado88 merged 4 commits intodevfrom
aPreciado88 merged 4 commits intodevfrom
Conversation
github-actions
Bot
added
the
chore
aPreciado88
added
the
pr ready for visual snapshots
Contributor
Author
|
@ashetland @SkyeSeitz Can you please take a look? |
aPreciado88
changed the title
ashetland
reviewed
Mar 18, 2025
| @apply focus-inset border-b-4; | ||
| padding-block-start: theme("spacing.1"); | ||
| border-block-end-width: theme("spacing.1"); | ||
| @apply bg-foreground-2 text-color-2 focus-inset; |
Contributor
There was a problem hiding this comment.
We shouldn't revert the changes we made on :focus. I'll update the issue to remove that ask.
aPreciado88
added
pr ready for visual snapshots
aPreciado88
added
pr ready for visual snapshots
Contributor
|
LGTM! |
jcfranco
approved these changes
Mar 19, 2025
Member
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
Code changes LGTM!
Since not all interaction state changes were reverted, can you rename the PR title to be more specific? Maybe "restore hover state styles" or something similar?
aPreciado88
changed the title
aPreciado88
deleted the
aPreciado88/11760-menu-revert-interaction-state-changes
branch
benelan
added a commit
that referenced
this pull request
Mar 24, 2025
* origin/dev: (61 commits) build(deps): update dependency stylelint to v16.16.0 (#11784) build(deps): update dependency type-fest to v4.37.0 (#11785) chore: release next build(deps): update eslint (#11786) docs: update list of contributors (#11780) feat(combobox-item): add component tokens (#11645) chore: release next feat: add browser join and browser plus (#11779) build(deps): update storybook monorepo to v8.6.6 (#11763) build(deps): update dependency lint-staged to v15.5.0 (#11764) docs: update list of contributors (#11769) build: update browserslist db (#11773) chore: release next feat(combobox, combobox-item-group): add component tokens (#11623) fix: Update README.md (#11768) fix: Update README.md (#11767) fix: Update README.md (#11765) revert(menu-item): revert hover state interaction changes (#11761) refactor(filter): remove unused styles (#11758) chore: use Vite for `@esri/eslint-plugin-calcite-components` build (#11752) ...
benelan
added a commit
that referenced
this pull request
Mar 24, 2025
…igration-ssr * origin/dev: (278 commits) build(deps): update storybook monorepo to v8.6.7 (#11783) build: update browserslist db (#11792) build(deps): update dependency stylelint to v16.16.0 (#11784) build(deps): update dependency type-fest to v4.37.0 (#11785) chore: release next build(deps): update eslint (#11786) docs: update list of contributors (#11780) feat(combobox-item): add component tokens (#11645) chore: release next feat: add browser join and browser plus (#11779) build(deps): update storybook monorepo to v8.6.6 (#11763) build(deps): update dependency lint-staged to v15.5.0 (#11764) docs: update list of contributors (#11769) build: update browserslist db (#11773) chore: release next feat(combobox, combobox-item-group): add component tokens (#11623) fix: Update README.md (#11768) fix: Update README.md (#11767) fix: Update README.md (#11765) revert(menu-item): revert hover state interaction changes (#11761) ...
benelan
pushed a commit
that referenced
this pull request
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #11760
Summary
Revert the following changes: