Skip to content

refactor(filter): remove unused styles#11758

Merged
Elijbet merged 3 commits intodevfrom
elijbet/7180-add-filter-tokens
Mar 19, 2025
Merged

refactor(filter): remove unused styles#11758
Elijbet merged 3 commits intodevfrom
elijbet/7180-add-filter-tokens

Conversation

@Elijbet
Copy link
Copy Markdown
Contributor

@Elijbet Elijbet commented Mar 17, 2025

Related Issue: N/A

Remove unused styles.

@github-actions github-actions Bot added the enhancement Issues tied to a new feature or request. label Mar 17, 2025
@Elijbet Elijbet marked this pull request as ready for review March 17, 2025 20:20
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Mar 17, 2025
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify some of these classes are even used? it seems like some of them can be removed.

Comment thread packages/calcite-components/src/components/filter/filter.scss Outdated
Comment thread packages/calcite-components/src/components/filter/filter.scss Outdated
Comment thread packages/calcite-components/src/components/filter/filter.scss Outdated
Comment thread packages/calcite-components/src/components/filter/filter.scss Outdated
@Elijbet Elijbet marked this pull request as draft March 18, 2025 02:14
@Elijbet Elijbet changed the title feat(filter): add component tokens refactor(filter): remove unused styles Mar 18, 2025
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 18, 2025
@Elijbet Elijbet marked this pull request as ready for review March 18, 2025 21:31
@macandcheese macandcheese self-requested a review March 19, 2025 17:32
Copy link
Copy Markdown
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Elijbet Elijbet merged commit 81ff609 into dev Mar 19, 2025
18 checks passed
@Elijbet Elijbet deleted the elijbet/7180-add-filter-tokens branch March 19, 2025 17:48
benelan added a commit that referenced this pull request Mar 24, 2025
* origin/dev: (61 commits)
  build(deps): update dependency stylelint to v16.16.0 (#11784)
  build(deps): update dependency type-fest to v4.37.0 (#11785)
  chore: release next
  build(deps): update eslint (#11786)
  docs: update list of contributors (#11780)
  feat(combobox-item): add component tokens (#11645)
  chore: release next
  feat: add browser join and browser plus (#11779)
  build(deps): update storybook monorepo to v8.6.6 (#11763)
  build(deps): update dependency lint-staged to v15.5.0 (#11764)
  docs: update list of contributors (#11769)
  build: update browserslist db (#11773)
  chore: release next
  feat(combobox, combobox-item-group): add component tokens (#11623)
  fix: Update README.md (#11768)
  fix: Update README.md (#11767)
  fix: Update README.md (#11765)
  revert(menu-item): revert hover state interaction changes (#11761)
  refactor(filter): remove unused styles (#11758)
  chore: use Vite for `@esri/eslint-plugin-calcite-components` build (#11752)
  ...
benelan pushed a commit that referenced this pull request Mar 26, 2025
**Related Issue:** N/A

Remove unused styles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants