Conversation
fbddf02 to
df2138b
Compare
jcfranco
left a comment
There was a problem hiding this comment.
Awesome stuff, @Elijbet! 🎉
Before merging, could you update the PR to only list components with width/height-prop-related updates?
The commit type might also need to be feat since we’re adding new properties for consistency. If there weren’t new props involved, deprecate would’ve been perfect. @geospatialem @DitwanP
Once the comments are addressed, this should be good to go!
Actually, we could leave this as is and use commit overrides to follow the steps outlined here. Sidebar: @DitwanP is the above recommendation in our internal doc? I wasn't able find it. |
We could indeed have the commit type as feat and then add a deprecation commit message to the body in order to list that separately on the changelog if that's what you're asking. And here's the link to the wiki section that covers this. |
|
@DitwanP Thanks for the link! |
**Related Issue:** #6172 ## Summary Refactor to consolidate `width/height` and `widthScale/heightScale` into a single property `width` with `s / m / l / auto / full` as options, and `height` with `s / m / l`. Deprecate `widthScale` and `heightScale` properties and the `half` value. Components addressed: - `button` - `dialog` - `dropdown` - `notice` - `segmented-control` - `select` - `sheet` - `shell-panel` - `split-button` deprecate: deprecate widthScale/heightScale properties in favor of width/height.
Related Issue: #6172
Summary
Refactor to consolidate
width/heightandwidthScale/heightScaleinto a single propertywidthwiths / m / l / auto / fullas options, andheightwiths / m / l. DeprecatewidthScaleandheightScaleproperties and thehalfvalue.Components addressed:
buttondialogdropdownnoticesegmented-controlselectsheetshell-panelsplit-buttondeprecate: deprecate widthScale/heightScale properties in favor of width/height.