deprecate: deprecate widthScale/heightScale in favor of width/height

[Elijbet]

Related Issue: #6172

Summary

Refactor to consolidate width/height and widthScale/heightScale into a single property width with s / m / l / auto / full as options, and height with s / m / l. Deprecate widthScale and heightScale properties and the half value.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

[jcfranco]

Once feedback is addressed, this should be good to merge!

📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏
📏📐📏📏📏📐📏📏📐📐📏📏📐📐📐📏📏📐📐📐📏📐📐📐📐📏📐📏
📏📐📐📏📏📐📏📐📏📏📐📏📏📐📏📏📐📏📏📏📏📐📏📏📏📏📐📏
📏📐📏📐📏📐📏📐📏📏📐📏📏📐📏📏📐📏📏📏📏📐📐📐📏📏📐📏
📏📐📏📏📐📐📏📐📏📏📐📏📏📐📏📏📐📏📏📏📏📐📏📏📏📏📏📏
📏📐📏📏📏📐📏📏📐📐📏📏📐📐📐📏📏📐📐📐📏📐📐📐📐📏📐📏
📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏📏

[eriklharper]

Could you do export type Width = Scale & "auto" | "half" | "full";? Same for Height above.

[eriklharper]

I guess Height would just be export type Height = Scale;

[Elijbet]

On the second thought, I feel like it might make things a bit confusing to read. Height, Width, and Scale are different props even though they have an overlap in type (with type Scale). s/m/l for scale does something else for width/height. Should they just have their own type names? It hurts my eyes to read type Height = Scale :)

[eriklharper]

I suggested that purely for DRY reasons. Its really just a union type to keep from having to define "s" | "m" | "l" in 3 different places.

[eriklharper]

But yeah for type Height = Scale, agree it does look weird, but it has more semantics at least. I'll let others chime in on it, curious to hear other opinions. @jcfranco

[Elijbet]

This PR has had test timeout issues on local machine and coupled with lumina migration it was cleaner to start a new branch deprecate: deprecate widthScale/heightScale in favor of width/height #10786