Skip to content

chore: cherry-pick patch commits to main#10528

Merged
benelan merged 7 commits intomainfrom
benelan/cherry-pick-patches
Oct 11, 2024
Merged

chore: cherry-pick patch commits to main#10528
benelan merged 7 commits intomainfrom
benelan/cherry-pick-patches

Conversation

@benelan
Copy link
Copy Markdown
Contributor

@benelan benelan commented Oct 11, 2024 •
edited
Loading

Summary

Cherry-pick the following patch commits to main:

Important

This PR must be rebase-merged

jcfranco and others added 7 commits October 11, 2024 12:25
@jcfranco @benelan
docs(accordion-item): fix deprecation tag (#10479)
31abf45
@driskull @benelan
fix(dialog): no longer apply transform styling unless dragEnabled or …
e63054c 
…resizable (#10503)

**Related Issue:** #10500

## Summary

- no longer apply transform styling unless dragEnabled or resizable
- add e2e test
@geospatialem @benelan
docs(shell-center-row): add logger + component deprecation context (#…
0901181 
…10507)
@anveshmekala @benelan
fix(combobox): restores filterText when filtered items are empty (#…
56cb787 
…10498)

**Related Issue:** #10156

## Summary

Restores `filterText` when filtered items are empty.
@jcfranco @benelan
fix(notice): ensure closed notice does not affect layout (#10518)
871344a
@alisonailea @benelan
fix(chip): fix close icon color inconsistency (#10493)
b89164d 
**Related Issue:** #10428

## Summary

Mitigates the --calcite-chip-close-icon-color token inconsistency.
<img width="229" alt="Screenshot 2024-10-07 at 9 20 41 AM"
src="https://github.com/user-attachments/assets/ec410639-2767-4c01-8479-c2e24801884d">
@driskull @benelan
revert(panel): revert relative positioning on content (#10496)
4aa39b2 
**Related Issue:** #10494 #10095

## Summary

- reverts position relative styling
- #10119 should be verified again
@benelan benelan requested a review from jcfranco as a code owner October 11, 2024 19:30
@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Oct 11, 2024
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Oct 11, 2024
@benelan benelan merged commit e8cc258 into main Oct 11, 2024
@benelan benelan deleted the benelan/cherry-pick-patches branch October 11, 2024 21:29
@github-actions github-actions Bot added this to the 2024-10-29 - Oct Milestone milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@benelan benelan

Labels

chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Milestone

2024-10-29 - Oct Milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@benelan @jcfranco @driskull @geospatialem @anveshmekala @alisonailea