fix(panel): revert relative positioning on content#10496
Merged
Conversation
driskull
added
the
pr ready for visual snapshots
github-actions
Bot
added
the
chore
Member
Author
|
The problem with reverting this is when you place a shell inside of a panel or dialog, it will go outside of the content because the position relative is not there. If we revert, we would break this fix. Shell is positioned absolutely by default which may be odd. But it does seem like other elements shouldn't go outside of the panel content if positioned absolutely so the relative does make sense here. |
…sri/calcite-design-system into dris0000/panel-revert-relative-content
driskull
added
pr ready for visual snapshots
jcfranco
approved these changes
Oct 10, 2024
Member
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
LGTM!
Before merging, since this fixes a regression, can you use fix as the commit type, so it shows up in the changelog?
driskull
added
the
bug
6 tasks
driskull
changed the title
benelan
pushed a commit
that referenced
this pull request
Oct 11, 2024
benelan
pushed a commit
that referenced
this pull request
Oct 11, 2024
Merged
benelan
added a commit
that referenced
this pull request
Oct 11, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.13.1</summary> ## [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1) (2024-10-11) ### Bug Fixes * **chip:** Fix close icon color inconsistency ([#10493](#10493)) ([80b75c2](80b75c2)) * **combobox:** Restores `filterText` when filtered items are empty ([#10498](#10498)) ([6667c2a](6667c2a)) * **dialog:** No longer apply transform styling unless dragEnabled or resizable ([#10503](#10503)) ([e93fdbc](e93fdbc)) * **notice:** Ensure closed notice does not affect layout ([#10518](#10518)) ([655bbb7](655bbb7)) * **fix(panel):** Revert relative positioning on content ([#10496](#10496)) ([239f4da](239f4da)) </details> <details><summary>@esri/calcite-components-angular: 2.13.1</summary> ## [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1) (2024-10-11) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> <details><summary>@esri/calcite-components-react: 2.13.1</summary> ## [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1) (2024-10-11) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Ben Elan <no-reply@benelan.dev>
benelan
added a commit
that referenced
this pull request
Oct 11, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1) (2024-10-11) * **chip:** Fix close icon color inconsistency ([#10493](#10493)) ([80b75c2](80b75c2)) * **combobox:** Restores `filterText` when filtered items are empty ([#10498](#10498)) ([6667c2a](6667c2a)) * **dialog:** No longer apply transform styling unless dragEnabled or resizable ([#10503](#10503)) ([e93fdbc](e93fdbc)) * **notice:** Ensure closed notice does not affect layout ([#10518](#10518)) ([655bbb7](655bbb7)) * **fix(panel):** Revert relative positioning on content ([#10496](#10496)) ([239f4da](239f4da)) </details> <details><summary>@esri/calcite-components-angular: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1) (2024-10-11) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> <details><summary>@esri/calcite-components-react: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1) (2024-10-11) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Ben Elan <no-reply@benelan.dev>
benelan
added a commit
that referenced
this pull request
Oct 11, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1) (2024-10-11) * **chip:** Fix close icon color inconsistency ([#10493](#10493)) ([80b75c2](80b75c2)) * **combobox:** Restores `filterText` when filtered items are empty ([#10498](#10498)) ([6667c2a](6667c2a)) * **dialog:** No longer apply transform styling unless dragEnabled or resizable ([#10503](#10503)) ([e93fdbc](e93fdbc)) * **notice:** Ensure closed notice does not affect layout ([#10518](#10518)) ([655bbb7](655bbb7)) * **fix(panel):** Revert relative positioning on content ([#10496](#10496)) ([239f4da](239f4da)) </details> <details><summary>@esri/calcite-components-angular: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1) (2024-10-11) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> <details><summary>@esri/calcite-components-react: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1) (2024-10-11) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <calcite-admin@esri.com>
benelan
added a commit
that referenced
this pull request
Feb 8, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1) (2024-10-11) * **chip:** Fix close icon color inconsistency ([#10493](#10493)) ([80b75c2](80b75c2)) * **combobox:** Restores `filterText` when filtered items are empty ([#10498](#10498)) ([6667c2a](6667c2a)) * **dialog:** No longer apply transform styling unless dragEnabled or resizable ([#10503](#10503)) ([e93fdbc](e93fdbc)) * **notice:** Ensure closed notice does not affect layout ([#10518](#10518)) ([655bbb7](655bbb7)) * **fix(panel):** Revert relative positioning on content ([#10496](#10496)) ([239f4da](239f4da)) </details> <details><summary>@esri/calcite-components-angular: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1) (2024-10-11) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> <details><summary>@esri/calcite-components-react: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1) (2024-10-11) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <calcite-admin@esri.com>
benelan
added a commit
that referenced
this pull request
Mar 26, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1) (2024-10-11) * **chip:** Fix close icon color inconsistency ([#10493](#10493)) ([80b75c2](80b75c2)) * **combobox:** Restores `filterText` when filtered items are empty ([#10498](#10498)) ([6667c2a](6667c2a)) * **dialog:** No longer apply transform styling unless dragEnabled or resizable ([#10503](#10503)) ([e93fdbc](e93fdbc)) * **notice:** Ensure closed notice does not affect layout ([#10518](#10518)) ([655bbb7](655bbb7)) * **fix(panel):** Revert relative positioning on content ([#10496](#10496)) ([239f4da](239f4da)) </details> <details><summary>@esri/calcite-components-angular: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1) (2024-10-11) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> <details><summary>@esri/calcite-components-react: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1) (2024-10-11) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <calcite-admin@esri.com>
benelan
added a commit
that referenced
this pull request
May 14, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1) (2024-10-11) * **chip:** Fix close icon color inconsistency ([#10493](#10493)) ([80b75c2](80b75c2)) * **combobox:** Restores `filterText` when filtered items are empty ([#10498](#10498)) ([6667c2a](6667c2a)) * **dialog:** No longer apply transform styling unless dragEnabled or resizable ([#10503](#10503)) ([e93fdbc](e93fdbc)) * **notice:** Ensure closed notice does not affect layout ([#10518](#10518)) ([655bbb7](655bbb7)) * **fix(panel):** Revert relative positioning on content ([#10496](#10496)) ([239f4da](239f4da)) </details> <details><summary>@esri/calcite-components-angular: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1) (2024-10-11) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> <details><summary>@esri/calcite-components-react: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1) (2024-10-11) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <calcite-admin@esri.com>
benelan
added a commit
that referenced
this pull request
Sep 16, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.0...@esri/calcite-components@2.13.1) (2024-10-11) * **chip:** Fix close icon color inconsistency ([#10493](#10493)) ([80b75c2](80b75c2)) * **combobox:** Restores `filterText` when filtered items are empty ([#10498](#10498)) ([6667c2a](6667c2a)) * **dialog:** No longer apply transform styling unless dragEnabled or resizable ([#10503](#10503)) ([e93fdbc](e93fdbc)) * **notice:** Ensure closed notice does not affect layout ([#10518](#10518)) ([655bbb7](655bbb7)) * **fix(panel):** Revert relative positioning on content ([#10496](#10496)) ([239f4da](239f4da)) </details> <details><summary>@esri/calcite-components-angular: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.0...@esri/calcite-components-angular@2.13.1) (2024-10-11) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> <details><summary>@esri/calcite-components-react: 2.13.1</summary> [2.13.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.0...@esri/calcite-components-react@2.13.1) (2024-10-11) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0 to 2.13.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <calcite-admin@esri.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #10494 #10095
BEGIN_COMMIT_OVERRIDE
fix(panel): revert relative positioning on content #10494
END_COMMIT_OVERRIDE
Summary