Conversation
github-actions
Bot
added
the
chore
driskull
changed the title
driskull
added
the
skip visual snapshots
|
@geospatialem could you review the strings? |
|
@geospatialem instead of using direction like
Then again, maybe its ok to leave as top/bottom/up/down since I don't think we'll do horizontal sorting. Example UI for context 
If you want to test it out a bit, you can use this PR: #10480 |
There was a problem hiding this comment.
LGTM! 💪🏻
@geospatialem instead of using direction like up/down/top/bottom, would it be better to use non directional terms?
forward/backward/start/end
ahead/behind/start/end
next/previous/first/last
@driskull Think its okay to leave as-is, while we could have more coverage and consistency, this seems a bit more confusing to list "Move to start" / "Move to end". If we do move to horizontal sorting we could consider alternative approaches in the future.
* origin/dev: (230 commits) chore: release next chore(sort-handle): add messages (#10474) feat(accordion-item): stretch slotted actions to fill its height (#9250) chore: release next feat(dialog, modal, popover, input-date-picker, input-time-picker, sheet): support stacked component sequential closing with escape (#9231) chore: remove commented-out code (#10478) chore: add cssrem VSCode extension recommendation (#10300) docs(accordion-item): fix deprecation tag (#10479) chore: release next feat(stepper-item): update component's active state background color. (#10475) refactor: use `requestAnimationFrame` to replace `readTask` (#10432) chore: release next fix(tip): fix rendering tied to named-slot content (#10470) ci: compile estimate totals per milestone (#10442) chore: release next fix(modal): fix rendering tied to named-slot content (#10469) chore: release next fix(shell-center-row): fix rendering tied to named-slot content (#10451) fix(inline-editable): fix rendering tied to default slot content (#10456) fix(input, input-number, input-text): should not set slotted actions to be disabled (#10458) ...
**Related Issue:** #7537 ## Summary - add messages for translation
3 participants
Related Issue: #7537
Summary