chore: add cssrem VSCode extension recommendation#10300
Conversation
jcfranco
added
the
skip visual snapshots
github-actions
Bot
added
the
chore
|
Per my comment on #10179, I don't think this needs to be added as it's solving for a short-term problem. Perhaps we should reprioritize the switch to rems in the new spacing tokens so it can be used sooner rather than later @SkyeSeitz @ashetland |
|
Noted, but I’d really like to avoid the noise and overhead of manually adding conversion comments. We could treat this as a temporary extension and remove it once the rem switch is in place. |
|
With this extension, all these tokens will have their values replaced with pixels. When the time comes to find/replace these static values with spacing tokens it's going to be a lot easier to find these with the "noise" than to try and filter out all the other pixel values that currently exist for other reasons. |
There’s a miscommunication. I wasn't proposing this extension to switch units, but rather to display the conversion within the editor. To be clear, we would keep rem values, and this would just help display their pixel conversion. The file from the linked discussion isn’t the only place where this occurs.
If we’re adding these comments for tracking and future replacement, let’s make sure the comments are clear about their purpose. |
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
Bot
added
the
Stale
jcfranco
removed
the
Stale
jcfranco
requested review from
Elijbet,
alisonailea,
anveshmekala,
driskull,
eriklharper and
macandcheese
* origin/dev: (230 commits) chore: release next chore(sort-handle): add messages (#10474) feat(accordion-item): stretch slotted actions to fill its height (#9250) chore: release next feat(dialog, modal, popover, input-date-picker, input-time-picker, sheet): support stacked component sequential closing with escape (#9231) chore: remove commented-out code (#10478) chore: add cssrem VSCode extension recommendation (#10300) docs(accordion-item): fix deprecation tag (#10479) chore: release next feat(stepper-item): update component's active state background color. (#10475) refactor: use `requestAnimationFrame` to replace `readTask` (#10432) chore: release next fix(tip): fix rendering tied to named-slot content (#10470) ci: compile estimate totals per milestone (#10442) chore: release next fix(modal): fix rendering tied to named-slot content (#10469) chore: release next fix(shell-center-row): fix rendering tied to named-slot content (#10451) fix(inline-editable): fix rendering tied to default slot content (#10456) fix(input, input-number, input-text): should not set slotted actions to be disabled (#10458) ...
4 participants
Related Issue: N/A
Summary
Adds the
cssremextension to display unit conversions within the editor. This will help avoid adding comments for unit conversions (see #10179 (comment)).