Skip to content

chore: stop requesting review from ben/franco for all PRs#10040

Merged
benelan merged 2 commits intodevfrom
benelan/codeowner-regex-maybe
Aug 12, 2024
Merged

chore: stop requesting review from ben/franco for all PRs#10040
benelan merged 2 commits intodevfrom
benelan/codeowner-regex-maybe

Conversation

@benelan
Copy link
Copy Markdown
Contributor

@benelan benelan commented Aug 12, 2024

Summary

Code owners is requesting review from Franco and I to all pull requests. It might be because we are the first item on the list and there is no catch-all. Hopefully adding a catch-all that assigns no one will fix the issue

@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Aug 12, 2024
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Aug 12, 2024
@jcfranco
Copy link
Copy Markdown
Member

So maybe CODEOWNERS uses regex, in which case .* means "everything".

So weird. Based on the doc, it seems .* would only target .-leading files/directories.

@benelan benelan merged commit ab3fb3b into dev Aug 12, 2024
@benelan benelan deleted the benelan/codeowner-regex-maybe branch August 12, 2024 22:01
@github-actions github-actions Bot added this to the 2024-08-27 - Aug Release milestone Aug 12, 2024
benelan added a commit that referenced this pull request Aug 13, 2024
…to-monorepo

* origin/dev: (37 commits)
  chore: release next
  fix(tree,tree-item): replace checkbox with div and a11y attributes (#9849)
  feat(combobox-item): add `heading` property (deprecates `textLabel`) and add `label` property (#9987)
  chore: stop requesting review from ben/franco for all PRs (#10040)
  feat: add close-caption, transcript, flag, and flag-slash (#10039)
  build(deps): update dependency @cspell/eslint-plugin to v8.13.2 (#10036)
  build(deps): update angular-cli monorepo to v18.1.4 (#10035)
  build(deps): clean up ui-icon dependencies (#10024)
  build: update browserslist db (#10033)
  docs: update component READMEs (#10034)
  ci: fix chromatic and pr-semantic check trigger events (#10041)
  chore: release next
  fix(label): prevent focusing and toggling elements slotted within a label when a text selection occurs (#9990)
  build(deps): update dependency @floating-ui/dom to v1.6.9 (#10025)
  build(deps): update dependency postcss to v8.4.41 (#10027)
  ci: new version of husky no longer need npx (#10030)
  build(deps): update dependency lerna to v8.1.8 (#10026)
  build(deps): update dependency chromatic to v11.7.0 (#9995)
  build(deps): update dependency eslint-plugin-jsdoc to v48.11.0 (#9997)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants